public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Artur Weber <aweber.kernel@gmail.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 3/3] ARM: dts: samsung: exynos4212-tab3: Fix headset mic, add jack detection
Date: Mon, 6 May 2024 08:31:14 +0200	[thread overview]
Message-ID: <d1007753-bdcf-4db9-bb01-b36e742cee4b@kernel.org> (raw)
In-Reply-To: <20240503-midas-wm1811-gpio-jack-v1-3-e8cddbd67cbf@gmail.com>

On 03/05/2024 20:55, Artur Weber wrote:
> Add the necessary properties to the samsung,midas-audio node to allow
> for headset jack detection, set up the mic bias regulator GPIO and fix
> some other small issues with the sound setup.
> 
> Signed-off-by: Artur Weber <aweber.kernel@gmail.com>

...

> +
>  &bus_acp {
>  	devfreq = <&bus_dmc>;
>  	status = "okay";
> @@ -505,12 +521,11 @@ &i2c_4 {
>  	wm1811: audio-codec@1a {
>  		compatible = "wlf,wm1811";
>  		reg = <0x1a>;
> -		clocks = <&pmu_system_controller 0>;
> -		clock-names = "MCLK1";
> +		clocks = <&pmu_system_controller 0>,
> +			 <&s5m8767_osc S2MPS11_CLK_BT>;
> +		clock-names = "MCLK1", "MCLK2";
>  		interrupt-controller;
>  		#interrupt-cells = <2>;
> -		interrupt-parent = <&gpx3>;
> -		interrupts = <6 IRQ_TYPE_LEVEL_HIGH>;

Does not look related at all to the patch.


Best regards,
Krzysztof


  reply	other threads:[~2024-05-06  6:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-03 18:55 [PATCH 0/3] ASoC: samsung: midas-audio: Add GPIO-based headset jack detection Artur Weber
2024-05-03 18:55 ` [PATCH 1/3] ASoC: dt-bindings: samsung,midas-audio: " Artur Weber
2024-05-06  6:28   ` Krzysztof Kozlowski
2024-05-03 18:55 ` [PATCH 2/3] ASoC: samsung: midas_wm1811: " Artur Weber
2024-05-06  6:30   ` Krzysztof Kozlowski
2024-05-03 18:55 ` [PATCH 3/3] ARM: dts: samsung: exynos4212-tab3: Fix headset mic, add " Artur Weber
2024-05-06  6:31   ` Krzysztof Kozlowski [this message]
2024-05-07 12:44     ` Artur Weber
2024-05-07 14:53       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d1007753-bdcf-4db9-bb01-b36e742cee4b@kernel.org \
    --to=krzk@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=aweber.kernel@gmail.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=robh@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=tiwai@suse.com \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox