Re: [PATCH] PNP support for i8042 driver

Dmitry Torokhov
2004-11-15T14:44:43Z

On Sun, 14 Nov 2004 13:22:21 +0100, matthieu castet
<castet.matthieu@free.fr> wrote:
> Dmitry Torokhov wrote:
>
>
> > On Saturday 13 November 2004 08:23 am, matthieu castet wrote:
> >
> >>Hi,
> >>this patch add PNP support for the i8042 driver in 2.6.10-rc1-mm5. Acpi
> >>is try before the pnp driver so if you don't disable ACPI or apply
> >>others pnpacpi patches, it won't change anything.
> >>
> >>Please review it and apply if possible
> >>
> >>thanks,
> >>
> >>Matthieu CASTET
> >>
> >>Signed-Off-By: Matthieu Castet <castet.matthieu@free.fr>
> >>
> >
> > Hi,
> >
> Hi,
> > Do we really need to keep those drivers loaded - i8042 will not
> > be hotplugged and ports are reserved anyway. We are only interested
> > in presence of the keyboard and mouse ports. Can we unregister
> > the drivers (both ACPI and PNP) right after registering and mark
> > all that stuff as __init/__initdata as in the patch below?
> It is better to keep pnp driver loaded because when it unload, the
> resources will be disabled, so for the motherboards that allow it the
> irq won't work anymore, and so the keyboard and mouse won't work...

Is it possible to leave the device in enabled state or enable device
after unloading the driver with PNP? All we need from PNP layer
for i8042 is to verify presence of the KBC, we don't need resource
management.The ports range is already marked as reserved, IRQ
will be requested if needed...

--
Dmitry