Re: [PATCH] PNP support for i8042 driver

Vojtech Pavlik
2004-11-17T10:07:48Z

On Sat, Nov 13, 2004 at 02:23:53PM +0100, matthieu castet wrote:
> Hi,
> this patch add PNP support for the i8042 driver in 2.6.10-rc1-mm5. Acpi
> is try before the pnp driver so if you don't disable ACPI or apply
> others pnpacpi patches, it won't change anything.
>
> Please review it and apply if possible

Ok, my thoughts on this:

It's OK to keep the device allocated to this driver via the PnP
subsystem, and not bother with releasing the code via
__initcall.

I agree that if there is a way to enumerate the device, (like
PnP, ACPI or OpenFirmware), we should use that instead of
probing and using a platform device for the controller.

I think that we should drop the ACPI support from i8042, in
favor of pnpacpi, because PnP is more generic and if the
keyboard device was listed in PnPBIOS instead of ACPI, it'll
still work.

--
Vojtech Pavlik
SuSE Labs, SuSE CR