public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Richard Koch <n1gp@hotmail.com>
Cc: linux-kernel@vger.kernel.org, vojtech@suse.cz,
	linux-input@atrey.karlin.mff.cuni.cz, torvalds@osdl.org,
	trivial@rustcorp.com.au
Subject: Re: [PATCH] adding the ICS MK712 touchscreen driver to 2.6
Date: Thu, 20 Jan 2005 13:04:03 -0500	[thread overview]
Message-ID: <d120d5000501201004539f4c3@mail.gmail.com> (raw)
In-Reply-To: <BAY16-F34ACC3DA65154E040BEC5987800@phx.gbl>

On Wed, 19 Jan 2005 16:18:49 -0500, Richard Koch <n1gp@hotmail.com> wrote:
> Please include the patch below to bring the ICS MK712 touchscreen controller
> support, which is in kernel 2.4, in to kernel 2.6.
> 
> This patch was constructed and applied to kernel version 2.6.10 and tested
> successfully on several Gateway AOL Connected Touchpad computers.
> 
> This was based on the mk712.c 2.4.28 version. No functional changes applied
> only minor
> changes to conform to the 2.6 build structure. I choose to place the driver
> under
> input/touchscreen as this seemed most appropriate.
> 

Hi,

I think that the driver should be integrated into 2.6 input system
before merging it into the kernel so touchscreen data can be accessed
through standard interfaces (evdev, mousedev, tsdev) without the need
for a special device.

Also MODULE_PARM is obsolete and shoudl be repleced with module_param().

-- 
Dmitry

  reply	other threads:[~2005-01-20 18:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-19 21:18 [PATCH] adding the ICS MK712 touchscreen driver to 2.6 Richard Koch
2005-01-20 18:04 ` Dmitry Torokhov [this message]
2005-02-05 19:31 ` Vojtech Pavlik
2005-02-05 21:02 ` Vojtech Pavlik
2005-02-05 23:00   ` Dmitry Torokhov
2005-02-06  9:25     ` Vojtech Pavlik
2005-02-06 17:53       ` Dmitry Torokhov
  -- strict thread matches above, loose matches on Subject: below --
2005-02-11 15:50 Richard Koch
2005-02-11 16:08 ` Vojtech Pavlik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d120d5000501201004539f4c3@mail.gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=dtor_core@ameritech.net \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=n1gp@hotmail.com \
    --cc=torvalds@osdl.org \
    --cc=trivial@rustcorp.com.au \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox