From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: Evgeniy Polyakov <johnpol@2ka.mipt.ru>,
Greg Kroah-Hartman <greg@kroah.com>,
linux-kernel@vger.kernel.org
Subject: Re: [-mm patch] connector.c: make notify_lock static
Date: Mon, 31 Jan 2005 10:00:51 -0500 [thread overview]
Message-ID: <d120d50005013107005a8c39b1@mail.gmail.com> (raw)
In-Reply-To: <20050131124119.GE18316@stusta.de>
On Mon, 31 Jan 2005 13:41:19 +0100, Adrian Bunk <bunk@stusta.de> wrote:
> notify_lock isn't a good name for a global lock.
> But since it's not used outside of the file, it can be made static.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.11-rc2-mm2-full/drivers/connector/connector.c.old 2005-01-31 13:09:14.000000000 +0100
> +++ linux-2.6.11-rc2-mm2-full/drivers/connector/connector.c 2005-01-31 13:09:28.000000000 +0100
> @@ -41,7 +41,7 @@
> module_param(cn_idx, uint, 0);
> module_param(cn_val, uint, 0);
>
> -spinlock_t notify_lock = SPIN_LOCK_UNLOCKED;
> +static spinlock_t notify_lock = SPIN_LOCK_UNLOCKED;
> static LIST_HEAD(notify_list);
>
> static struct cn_dev cdev;
>
Isn't this supposed to be "static DEFINE_SPINLOCK(notify_lock);" nowadays?
--
Dmitry
next prev parent reply other threads:[~2005-01-31 15:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-31 12:41 [-mm patch] connector.c: make notify_lock static Adrian Bunk
2005-01-31 13:06 ` Evgeniy Polyakov
2005-01-31 15:00 ` Dmitry Torokhov [this message]
2005-01-31 16:07 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d50005013107005a8c39b1@mail.gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=bunk@stusta.de \
--cc=dtor_core@ameritech.net \
--cc=greg@kroah.com \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox