From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Vojtech Pavlik <vojtech@suse.cz>
Cc: Vojtech Pavlik <vojtech@suse.de>,
David Fries <dfries@mail.win.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2
Date: Mon, 7 Feb 2005 09:22:19 -0500 [thread overview]
Message-ID: <d120d500050207062257490ae2@mail.gmail.com> (raw)
In-Reply-To: <20050207122033.GA16959@ucw.cz>
On Mon, 7 Feb 2005 13:20:33 +0100, Vojtech Pavlik <vojtech@suse.cz> wrote:
> On Sun, Feb 06, 2005 at 08:21:13PM -0500, Dmitry Torokhov wrote:
> > > > Opening braces should go on the same line as the statement (if (...) {).
> > >
> > > How about this patch?
> >
> > Looks fine now. Hmm, wait a sec... Don't we also need kill_fasync calls in
> > disconnect routines as well?
>
> This should do it:
>
Not quite...
> + list_for_each_entry(list, &evdev->list, node)
> + kill_fasync(&list->fasync, SIGIO, POLLHUP | POLLERR);
Wrong band constants - for SIGIO POLL_HUP and POLL_ERR should be used.
/*
* SIGPOLL si_codes
*/
#define POLL_IN (__SI_POLL|1) /* data input available */
#define POLL_OUT (__SI_POLL|2) /* output buffers available */
#define POLL_MSG (__SI_POLL|3) /* input message available */
#define POLL_ERR (__SI_POLL|4) /* i/o error */
#define POLL_PRI (__SI_POLL|5) /* high priority input available */
#define POLL_HUP (__SI_POLL|6) /* device disconnected */
--
Dmitry
next prev parent reply other threads:[~2005-02-07 14:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20041123212813.GA3196@spacedout.fries.net>
2005-02-01 14:52 ` [PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2 David Fries
2005-02-01 15:24 ` Dmitry Torokhov
2005-02-06 13:12 ` Vojtech Pavlik
2005-02-07 1:21 ` Dmitry Torokhov
2005-02-07 6:59 ` Vojtech Pavlik
2005-02-07 12:20 ` Vojtech Pavlik
2005-02-07 14:22 ` Dmitry Torokhov [this message]
2005-02-07 18:51 ` Vojtech Pavlik
2005-02-08 15:29 ` David Fries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d500050207062257490ae2@mail.gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=dfries@mail.win.org \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=vojtech@suse.cz \
--cc=vojtech@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox