From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "colbuse@ensisun.imag.fr" <colbuse@ensisun.imag.fr>
Cc: linux-kernel@vger.kernel.org, akpm@zip.com.au
Subject: Re: [patch 3/2] drivers/char/vt.c: remove unnecessary code
Date: Mon, 28 Feb 2005 08:48:12 -0500 [thread overview]
Message-ID: <d120d5000502280548733724a0@mail.gmail.com> (raw)
In-Reply-To: <1109596437.422319158044b@webmail.imag.fr>
On Mon, 28 Feb 2005 14:13:57 +0100, colbuse@ensisun.imag.fr
<colbuse@ensisun.imag.fr> wrote:
>
> >On Mon, Feb 28, 2005 at 01:57:59PM +0100, colbuse@xxxxxxxxxxxxxxx wrote:
> >> Please _don't_ apply this, but tell me what you think about it.
>
> >It's broken. 8)
>
> >> --- old/drivers/char/vt.c 2004-12-24 22:35:25.000000000 +0100
> >> +++ new/drivers/char/vt.c 2005-02-28 12:53:57.933256631 +0100
> >> @@ -1655,9 +1655,9 @@
> >> vc_state = ESnormal;
> >> return;
> >> case ESsquare:
> >> - for(npar = 0 ; npar < NPAR ; npar++)
> >> + for(npar = NPAR-1; npar < NPAR; npar--)
>
> >How many times do you want this for loop to run?
>
> NPAR times :-). As I stated, npar is unsigned.
>
for (npar = NPAR - 1; npar >= 0; npar--)
would be more readable and may be even faster on a dumb compiler than
your variant. Still, I'd have compiler worry about such
micro-optimizations.
--
Dmitry
next prev parent reply other threads:[~2005-02-28 13:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-28 13:13 [patch 3/2] drivers/char/vt.c: remove unnecessary code colbuse
2005-02-28 13:28 ` Russell King
2005-02-28 14:01 ` colbuse
2005-02-28 14:22 ` Arjan van de Ven
2005-02-28 14:43 ` Martin Mares
2005-02-28 14:57 ` Horst von Brand
2005-02-28 13:32 ` Adrian Bunk
2005-02-28 13:48 ` Dmitry Torokhov [this message]
2005-02-28 14:02 ` Arjan van de Ven
2005-02-28 14:06 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2005-02-28 15:06 colbuse
2005-02-28 16:44 ` Stelian Pop
2005-02-28 17:29 ` emmanuel.colbus@ensimag.imag.fr
2005-02-28 19:18 ` Stelian Pop
2005-02-28 20:30 ` Adrian Bunk
2005-02-28 12:57 colbuse
2005-02-28 13:02 ` Russell King
2005-02-28 13:33 ` linux-os
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d5000502280548733724a0@mail.gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=akpm@zip.com.au \
--cc=colbuse@ensisun.imag.fr \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox