Re: [PATCH] new driver for ITM Touch touchscreen

Hans-Christian Egtvedt
2005-03-04T16:21:17Z

On Fri, 2005-03-04 at 09:52 -0500, Dmitry Torokhov wrote:
> On Fri, 4 Mar 2005 14:03:37 +0200, Alexey Dobriyan <adobriyan@mail.ru> wrote:
> > On Friday 04 March 2005 12:30, Hans-Christian Egtvedt wrote:

<snip info about kref>

> As far as the driver goes:
>
> - yes, it does need input_sync;

One problem with input_sync is that the panel get's too fast, and double
click is experienced quite often, maybe some threshold is needed for low
values in Z-direction?

I'm probably doing something wrong here since I experience easy
doubleclicks when I just lightly touch the screen.

> - I prefer using input_set_abs_params instead of setting mix, max,
> flat and fuzz for each axis manually;

Thanks, I've adopted to those now, havn't had time to test with the
panel today, but my guess is that this dosn't make a big deal.

> - I believe "/* .. */" is preferred over "//"

Done.

> - kill the commented out bad prototypes.

Done.

> Also, is there a way to query the screen for actual size?

Sorry, the panel is a fixed size, and it gives out coordinates from 0 ->
4095 in both X- and Y-direction. In Z-direction (pressure strength) it
goes from 0 to 255.

Or did you want the size of the screen? Meaning you want to know if it's
a 15", 17" and so on?

--
Hans-Christian Egtvedt <hc@mivu.no>
MIVU Solutions DA