From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: David Brownell <david-b@pacbell.net>
Cc: linux-usb-devel@lists.sourceforge.net, Greg KH <greg@kroah.com>,
Dominik Brodowski <linux@dominikbrodowski.net>,
linux-kernel@vger.kernel.org, Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: [linux-usb-devel] Re: [RFC] Changes to the driver model class code.
Date: Tue, 15 Mar 2005 17:05:40 -0500 [thread overview]
Message-ID: <d120d5000503151405381f183a@mail.gmail.com> (raw)
In-Reply-To: <200503151314.40510.david-b@pacbell.net>
On Tue, 15 Mar 2005 13:14:40 -0800, David Brownell <david-b@pacbell.net> wrote:
> You still haven't answered my question. My observation was that
> only the class code can in any sense be called "new" ... so your
> blanket statement seemed to overlook several essential points!
>
> Which parts of the driver model were you thinking of?
>
> That pre-driver model stuff went away in maybe 2.6.5 or so, I
> forget just when.
I think I was shopping around for the examples of proper driver model
integration in 2.6.2 - 2.6.3 timeframe for the serio bus. I was
looking at how USB was working around the fact that one can not
add/remove children from the probe/remove methods. I can not tell you
what exactly gave me the impression that conversion is still in
progress, probably the comments like this:
/* FIXME should device_bind_driver() */
iface->driver = driver;
usb_set_intfdata(iface, priv);
return 0;
Now I see it was changed shortly after I looked there. And I see that
my impression was wrong, it _is_ tightly integrated with the driver
model now.
> If you think those changes can easily be
> reversed, I suggest you think again ... they enabled a LOT of
> likewise-overdue cleanups.
Note that I am arguing for keeping existing interface, not removing it.
--
Dmitry
next prev parent reply other threads:[~2005-03-15 22:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-15 17:08 [RFC] Changes to the driver model class code Greg KH
2005-03-15 17:09 ` Greg KH
2005-03-15 17:10 ` Greg KH
2005-03-15 17:10 ` Greg KH
2005-03-15 17:11 ` Greg KH
2005-03-15 17:47 ` Dmitry Torokhov
2005-03-15 19:34 ` Greg KH
2005-03-15 19:47 ` [linux-usb-devel] " Dmitry Torokhov
2005-03-15 20:15 ` Dominik Brodowski
2005-03-15 22:14 ` Greg KH
2005-03-16 1:01 ` Dominik Brodowski
2005-03-16 3:42 ` Dmitry Torokhov
2005-03-27 14:42 ` Dominik Brodowski
2005-03-15 19:08 ` Dominik Brodowski
2005-03-15 19:30 ` [linux-usb-devel] " Dmitry Torokhov
2005-03-15 19:34 ` Sean
2005-03-15 19:45 ` John Lenz
2005-03-15 19:51 ` Greg KH
2005-03-15 20:06 ` Dominik Brodowski
2005-03-15 20:14 ` [linux-usb-devel] " Dmitry Torokhov
2005-03-15 20:35 ` David Brownell
2005-03-15 20:48 ` Dmitry Torokhov
2005-03-15 21:14 ` David Brownell
2005-03-15 21:23 ` Dominik Brodowski
2005-03-15 22:05 ` Dmitry Torokhov [this message]
2005-03-15 22:29 ` David Brownell
2005-03-16 23:16 ` Jon Smirl
2005-03-17 6:17 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d5000503151405381f183a@mail.gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=david-b@pacbell.net \
--cc=dtor_core@ameritech.net \
--cc=greg@kroah.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=linux@dominikbrodowski.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox