From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S261280AbVGYOxP@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S261280AbVGYOxP (ORCPT <rfc822;willy@w.ods.org>);
	Mon, 25 Jul 2005 10:53:15 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261306AbVGYOud
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 25 Jul 2005 10:50:33 -0400
Received: from rproxy.gmail.com ([64.233.170.206]:56825 "EHLO rproxy.gmail.com")
	by vger.kernel.org with ESMTP id S261280AbVGYOtY convert rfc822-to-8bit
	(ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 25 Jul 2005 10:49:24 -0400
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=Ec0Wup5ZtF8qNXgEarLPFEKSVyfN8qxrW4OCF3VXqziSqgx590xv7G9eNZK7teKlC37cvYLGT4wMSdFExv+1EPXZLJTGDxuNCNvRt/moW4uDt22vfewpC/ZhXl3vt1dgKw8uNeDukfWR5Ru042NWJzkBJ8lrBHeKl8AcTSuUbNU=
Message-ID: <d120d5000507250748136a1e71@mail.gmail.com>
Date: Mon, 25 Jul 2005 09:48:37 -0500
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reply-To: dtor_core@ameritech.net
To: Jon Smirl <jonsmirl@gmail.com>
Subject: Re: [PATCH] driver core: Add the ability to unbind drivers to devices from userspace
Cc: linux-kernel@vger.kernel.org, Greg KH <greg@kroah.com>
In-Reply-To: <9e4733910507250728a7882d4@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Content-Disposition: inline
References: <9e47339105072421095af5d37a@mail.gmail.com>
	 <200507242358.12597.dtor_core@ameritech.net>
	 <9e4733910507250728a7882d4@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/25/05, Jon Smirl <jonsmirl@gmail.com> wrote:
> On 7/25/05, Dmitry Torokhov <dtor_core@ameritech.net> wrote:
> > On Sunday 24 July 2005 23:09, Jon Smirl wrote:
> > > I just pulled from GIT to test bind/unbind. I couldn't get it to work;
> > > it isn't taking into account the CR on the end of the input value of
> > > the sysfs attribute.  This patch will fix it but I'm sure there is a
> > > cleaner solution.
> > >
> >
> > "echo -n" should take care of this problem I think.
> 
> That will work around it but I think we should fix it.  Changing to
> strncmp() fixes most cases.
> 
> -       if (strcmp(name, dev->bus_id) == 0)
> +       if (strncmp(name, dev->bus_id, strlen(dev->bus_id)) == 0)
> 

This will produce "interesting results" if you have both "blah-1" and
"blah-10" devices on the bus.
-- 
Dmitry