From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Alexander Nyberg <alexn@telia.com>
Cc: Michael Stenzel <m.stenzel@tronix.homelinux.org>,
Vojtech Pavlik <vojtech@suse.cz>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [BUG] module ns558
Date: Wed, 10 Aug 2005 10:10:22 -0500 [thread overview]
Message-ID: <d120d50005081008106500b26d@mail.gmail.com> (raw)
In-Reply-To: <20050805193031.GA17969@localhost.localdomain>
On 8/5/05, Alexander Nyberg <alexn@telia.com> wrote:
>
> Please try this:
>
> Index: linux-2.6/drivers/input/gameport/ns558.c
> ===================================================================
> --- linux-2.6.orig/drivers/input/gameport/ns558.c 2005-07-31 18:10:26.000000000 +0200
> +++ linux-2.6/drivers/input/gameport/ns558.c 2005-08-05 21:20:59.000000000 +0200
> @@ -275,9 +275,9 @@
>
> static void __exit ns558_exit(void)
> {
> - struct ns558 *ns558;
> + struct ns558 *ns558, *safe;
>
> - list_for_each_entry(ns558, &ns558_list, node) {
> + list_for_each_entry_safe(ns558, safe, &ns558_list, node) {
> gameport_unregister_port(ns558->gameport);
> release_region(ns558->io & ~(ns558->size - 1), ns558->size);
> kfree(ns558);
> -
I think this one should go into 2.6.13 and probably in -stable too...
--
Dmitry
prev parent reply other threads:[~2005-08-10 15:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-05 18:52 [BUG] module ns558 Michael Stenzel
2005-08-05 19:30 ` Alexander Nyberg
2005-08-10 15:10 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d50005081008106500b26d@mail.gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=akpm@osdl.org \
--cc=alexn@telia.com \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=m.stenzel@tronix.homelinux.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox