From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Lee Revell <rlrevell@joe-job.com>
Cc: Rumen Ivanov Zarev <rzarev@its.caltech.edu>,
gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: Unhide SMBus on Compaq Evo N620c
Date: Tue, 6 Sep 2005 18:01:12 -0500 [thread overview]
Message-ID: <d120d500050906160158912aaa@mail.gmail.com> (raw)
In-Reply-To: <1126046590.13159.9.camel@mindpipe>
On 9/6/05, Lee Revell <rlrevell@joe-job.com> wrote:
> On Tue, 2005-09-06 at 13:39 -0700, Rumen Ivanov Zarev wrote:
> > Trivial patch against 2.6.13 to unhide SMBus on Compaq Evo N620c laptop using
> > Intel 82855PM chipset.
>
> > + } else if (unlikely(dev->subsystem_vendor == PCI_VENDOR_ID_COMPAQ)) {
>
> Should unlikely() be used for cases where the conditional will be true
> iff a specific piece of hardware is present? Seems like we'd always
> lose.
>
I would say that we should definitely not use [un]likely for code that
is executed once during boot.
--
Dmitry
next prev parent reply other threads:[~2005-09-06 23:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-06 20:39 [PATCH] PCI: Unhide SMBus on Compaq Evo N620c Rumen Ivanov Zarev
2005-09-06 22:43 ` Lee Revell
2005-09-06 22:59 ` Rumen Zarev
2005-09-06 23:01 ` Dmitry Torokhov [this message]
2005-09-07 18:12 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d500050906160158912aaa@mail.gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=dtor_core@ameritech.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rlrevell@joe-job.com \
--cc=rzarev@its.caltech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox