Re: [PATCH] PCI: Unhide SMBus on Compaq Evo N620c

Rumen Zarev
2005-09-06T22:59:37Z

Lee Revell wrote:
> On Tue, 2005-09-06 at 13:39 -0700, Rumen Ivanov Zarev wrote:
>
>>Trivial patch against 2.6.13 to unhide SMBus on Compaq Evo N620c laptop using
>>Intel 82855PM chipset.
>
>
>>+ } else if (unlikely(dev->subsystem_vendor == PCI_VENDOR_ID_COMPAQ)) {
>
>
> Should unlikely() be used for cases where the conditional will be true
> iff a specific piece of hardware is present? Seems like we'd always
> lose.
>
> Lee
>
>
>

I just copied some code that was already there and modified it for my
case. I don't really know HOW it works - I'm not much of a programmer
myself.

Rumen