Re: [PATCH 001/001] INPUT: new ioctl's to retrieve values of EV_REP and EV_SND event codes

Vojtech Pavlik
2006-04-25T15:26:04Z

On Tue, Apr 25, 2006 at 11:23:02AM -0400, Dmitry Torokhov wrote:
> On 4/25/06, Vojtech Pavlik <vojtech@suse.cz> wrote:
> > On Tue, Apr 25, 2006 at 09:19:42AM -0400, Dmitry Torokhov wrote:
> > > On 4/24/06, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> > > > On 4/24/06, Vojtech Pavlik <vojtech@suse.cz> wrote:
> > > > > On Mon, Apr 24, 2006 at 10:31:39AM -0400, Dmitry Torokhov wrote:
> > > > > >
> > > > > > Vojtech, could you remind me why EVIOC{G|S}REP were removed? Some
> > > > > > people want to have ability to separate keyboards (via grabbing); they
> > > > > > also might want to control repeat rate independently. Shoudl we
> > > > > > reinstate these ioctls?
> > > > >
> > > > > I believe they were replaced by the ability to send EV_REP style events
> > > > > to the device, setting the repeat rate.
> > > > >
> > > >
> > > > Argh, why am I always forgetting about ability to write events into devices?
> > >
> > > Thinking about it some more - writing to the event device is an
> > > elegant way to set repeat rate but how do you retrieve current repeat
> > > rate for a given device?
> >
> > You can't. And that's likely a problem that needs fixing.
> >
>
> So do you agree that we need to ressurect EVIOCGREP (and EVIOCSREP
> just to complement the interface)?

Yes. And EVIOCSREP should just generate the events needed to notify the
drivers to do the change.

--
Vojtech Pavlik
Director SuSE Labs