Re: [PATCH v4 2/4] drm/panel: Add refcount support

[Jani Nikula <jani.nikula@linux.intel.com>]

On Tue, 27 May 2025, Maxime Ripard <mripard@kernel.org> wrote:
> Hi,
>
> On Fri, May 23, 2025 at 02:34:05PM +0300, Jani Nikula wrote:
>> On Tue, 20 May 2025, Jani Nikula <jani.nikula@linux.intel.com> wrote:
>> > Maxime -
>> >
>> > I'm cutting a lot of context here. Not because I don't think it deserves
>> > an answer, but because I seem to be failing at communication.
>> >
>> > On Mon, 19 May 2025, Maxime Ripard <mripard@kernel.org> wrote:
>> >> You still haven't explained why it would take anything more than
>> >> registering a dumb device at probe time though.
>> >
>> > With that, do you mean a dumb struct device, or any struct device with a
>> > suitable lifetime, that we'd pass to devm_drm_panel_alloc()?
>> 
>> I'm no expert in ACPI, but I think it needs to be a struct device
>> embedded inside struct acpi_device to implement the
>> drm_panel_add_follower() lookup for ACPI.
>
> What data do you have in the ACPI tables to associate the HID
> touchscreen to the panel?
>
> drm_panel_add_follower use the DT to lookup the panel, so the panel must
> have a device->of_node pointer, so that obviously won't work, but it
> might with ACPI, or we might need to split that function into several
> parts to accomodate ACPI.

Personally, I'm pretty clueless about ACPI, but apparently it's possible
to add a _DSD to reference the panel.

And something like [1] could work to make drm_panel lookup agnostic to
DT/ACPI, but it's completely untested and unreviewed as of today. We'll
also need to find someone to help ensure that doesn't break DT systems.

Feedback is welcome, but please bear in mind I'm not even confident
enough to post it on dri-devel yet.


BR,
Jani.


[1] https://gitlab.freedesktop.org/jani/linux/-/commit/8ca2e1f25ca94c4ee094915a26781f9d9ace37af


-- 
Jani Nikula, Intel