From: Leon Hwang <leon.hwang@linux.dev>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: bpf@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
John Fastabend <john.fastabend@gmail.com>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Shuah Khan <shuah@kernel.org>,
Christian Brauner <brauner@kernel.org>,
Seth Forshee <sforshee@kernel.org>,
Yuichiro Tsuji <yuichtsu@amazon.com>,
Andrey Albershteyn <aalbersh@redhat.com>,
Willem de Bruijn <willemb@google.com>,
Jason Xing <kerneljasonxing@gmail.com>,
Tao Chen <chen.dylane@linux.dev>,
Mykyta Yatsenko <yatsenko@meta.com>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Anton Protopopov <a.s.protopopov@gmail.com>,
Amery Hung <ameryhung@gmail.com>, Rong Tao <rongtao@cestc.cn>,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
linux-kselftest@vger.kernel.org, kernel-patches-bot@fb.com
Subject: Re: [PATCH bpf-next v10 3/8] bpf: Refactor reporting log_true_size for prog_load
Date: Thu, 12 Feb 2026 13:50:55 +0800 [thread overview]
Message-ID: <d139fff6-2f30-43f0-acac-df5d389fc416@linux.dev> (raw)
In-Reply-To: <CAEf4Bzb-b+EcF1oLXA7mijL5kVmjpOuh2B+LPM9x4tAFOYHCsw@mail.gmail.com>
On 12/2/26 06:10, Andrii Nakryiko wrote:
> On Wed, Feb 11, 2026 at 7:13 AM Leon Hwang <leon.hwang@linux.dev> wrote:
>>
[...]
>> @@ -6241,7 +6244,11 @@ static int __sys_bpf(enum bpf_cmd cmd, bpfptr_t uattr, unsigned int size,
>> err = map_freeze(&attr);
>> break;
>> case BPF_PROG_LOAD:
>> - err = bpf_prog_load(&attr, uattr, size);
>> + if (from_user && size >= offsetofend(union bpf_attr, log_true_size))
>> + log_true_size = uattr.user + offsetof(union bpf_attr, log_true_size);
>
> LGTM, so
>
> Acked-by: Andrii Nakryiko <andrii@kernel.org>
>
Thanks for the review and the Ack!
> but it caught my eye that we will never return log_true_size if
> SYSCALL program tried to load another BPF program (light skeleton
> case), which seems limiting, but we can perhaps address that
> separately as a follow up
>
Correct.
Currently, struct bpf_verifier_log and the log_true_size
back-propagation mechanism are designed specifically for user space and
are not compatible with in-kernel callers.
I’ll look into whether this can be improved in a follow-up.
Thanks,
Leon
[...]
next prev parent reply other threads:[~2026-02-12 5:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 15:11 [PATCH bpf-next v10 0/8] bpf: Extend BPF syscall with common attributes support Leon Hwang
2026-02-11 15:11 ` [PATCH bpf-next v10 1/8] " Leon Hwang
2026-02-11 15:11 ` [PATCH bpf-next v10 2/8] libbpf: Add support for extended bpf syscall Leon Hwang
2026-02-11 15:11 ` [PATCH bpf-next v10 3/8] bpf: Refactor reporting log_true_size for prog_load Leon Hwang
2026-02-11 22:10 ` Andrii Nakryiko
2026-02-12 5:50 ` Leon Hwang [this message]
2026-03-03 16:32 ` Alexei Starovoitov
2026-03-04 5:47 ` Leon Hwang
2026-03-04 5:58 ` Alexei Starovoitov
2026-03-04 6:17 ` Leon Hwang
2026-02-11 15:11 ` [PATCH bpf-next v10 4/8] bpf: Add syscall common attributes support " Leon Hwang
2026-02-11 22:08 ` Andrii Nakryiko
2026-02-12 5:50 ` Leon Hwang
2026-02-18 18:44 ` Andrii Nakryiko
2026-02-11 15:11 ` [PATCH bpf-next v10 5/8] bpf: Add syscall common attributes support for btf_load Leon Hwang
2026-02-11 22:11 ` Andrii Nakryiko
2026-02-11 15:11 ` [PATCH bpf-next v10 6/8] bpf: Add syscall common attributes support for map_create Leon Hwang
2026-02-11 15:11 ` [PATCH bpf-next v10 7/8] libbpf: " Leon Hwang
2026-02-11 15:11 ` [PATCH bpf-next v10 8/8] selftests/bpf: Add tests to verify map create failure log Leon Hwang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d139fff6-2f30-43f0-acac-df5d389fc416@linux.dev \
--to=leon.hwang@linux.dev \
--cc=a.s.protopopov@gmail.com \
--cc=aalbersh@redhat.com \
--cc=ameryhung@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=chen.dylane@linux.dev \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kernel-patches-bot@fb.com \
--cc=kerneljasonxing@gmail.com \
--cc=kpsingh@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=rongtao@cestc.cn \
--cc=sdf@fomichev.me \
--cc=sforshee@kernel.org \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=willemb@google.com \
--cc=yatsenko@meta.com \
--cc=yonghong.song@linux.dev \
--cc=yuichtsu@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox