From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f97.google.com (mail-pj1-f97.google.com [209.85.216.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6470936EA8A for ; Tue, 5 May 2026 17:58:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.97 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778003936; cv=none; b=Hhpb1810CRba6sirt/RelMeZDSS1hTR4mLnoUwRqtzkOXmJ6EghDTuTNRJvHXV+FYUNSIYCB5pjtCU1tWD8NdD/oPSpLO8EJ2IrL33ho9HQHlqHKBjMzJ+mOf882MY2fwx/AVo00nq0GHeINYjV9vm2rT+z3aNLNJxQ/EB9kIko= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778003936; c=relaxed/simple; bh=VwEnrsNuQe9ObBc47UVFruD/Hq5jqBRsKOXR5Bfg4Rs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oxkcYOyfUSIpFHpBtJmGKP75UXLjvbAIFtg2o4n0vVoGqghllIXXgu31puR0X0YmSauVlRx6BiqOSUMKMbnBsEPjoOAd1xiFXiQsQXiuns5GV4ACtAPkkrndpiEHi5YXcd7o5wmfm+f6b3vZIWHHii56W2kPbBVt8ymrVIlnOHI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Jy7mbVa3; arc=none smtp.client-ip=209.85.216.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Jy7mbVa3" Received: by mail-pj1-f97.google.com with SMTP id 98e67ed59e1d1-365312a27abso2738584a91.3 for ; Tue, 05 May 2026 10:58:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778003935; x=1778608735; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=euKFIAQCeM55RulM535j7KBn6cys8J5H/Q721o26Boo=; b=Z6yBlYAZ9wYGLUcoNV8rFV1/0Dr0h2+cdHrMGJI9QbBitE1nJlpvWimHSYhsHuS+aI oi5Gb3bANO+ziJOD6U9aYSRp/vgRoVASupuVJsts6YKMvkU1LPwPdfzVhHwij1k/Xug+ Ed7Xf8l3hZOA1wseIbraZhVFv/vJ5dLPY+YeFI+G0DQU/5xJDC1S0lHLOUOuRsZvr4Me 0eXKGXKuIPwSr6A9iOiXR1KpMuiaxbYFnIWMwg11nb7Dt3RD5D1mxOske2cernNyeKJG Shv26DOTcM6dtO2YVcnacdvzXQ8o1ay3wbF1I/epx3v88oHTv1LIiopl5Sh4h7BysZKv Yz+A== X-Forwarded-Encrypted: i=1; AFNElJ/7iBYBHuwtFPx49SDP2BNZnlTUr2wSoJCl70cy8w04rbrjPO1CSNbNvQq0y94Ph9/7SZ3O60QKcJvUTN4=@vger.kernel.org X-Gm-Message-State: AOJu0YzVIoqNcfrupB4PGIhscPiWlAt2omQNb+OHUMcRy2iob3tgkf4m M/P6z4eGtfoXNNvwYeLx56RQCbxN92x8mt6pJa+yhMn1e7ilwNWMrv05EDNRyIkmUD28oYO27+h xiRV1HfhV72N6y7tr18IZgTaXqfG8fHNnGGu1CpQutl5svJ6llyMXrn1VIRVVZjex+/QHcQLrpb G3diyBCTSBwC+GXZZFMuVHeeNuEbtM8Fn79ClfnfMJ70P02lE3oXJziGM90n9TTgLFoPPbtMrNi DFLmSlCvPV5h+ppBPykapa8 X-Gm-Gg: AeBDiesHmzEqqWEIxIypmC+xAUURqf1ew5G4tp6uLSv8e64+4QTwE9N+kSa9gqPMMbf LuEXSOztN4RaPWvT72e7MHMV2OjPKk6fftQhkLZOiHfKgdBusQR6eRcEdQgt/Fo8aaEhp2ux/md Ryuz13bEKlrKpeucfcz9FBPFDTiTO1myq6zKbYA1aaW2SRsXnTwi/QpkGYdP8lWg+EOm/mmjdmL mojSKWIsBYq3NTTlSSQoJElRWw1LYuTYcrbP0N+s3ZJ34X/KvWpBhWvym1xzHlLwkdh2nWLIucj ILb5NcET3XHX9rnjQY+Gk9Gg+hjmPfZh/XhrKvhEKo6BnzATj0gGpzxIrtETGwuyi8i3gt4RWy2 YclpX2994oeahvWYXuWv63I8CDRHLsdmDXsnvzeJC+ZFHR4WcYlJVIm7CoKiwJyITbdwf4qB8EV K2jL4I5PfI2o0dr+3sLv1E X-Received: by 2002:a17:90a:e7c1:b0:35f:b306:5d47 with SMTP id 98e67ed59e1d1-3650cd85defmr15077975a91.1.1778003934721; Tue, 05 May 2026 10:58:54 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com ([144.49.247.127]) by smtp-relay.gmail.com with ESMTPS id 98e67ed59e1d1-365a4a05363sm6530a91.1.2026.05.05.10.58.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 May 2026 10:58:54 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-2c16233ee11so7364270eec.1 for ; Tue, 05 May 2026 10:58:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1778003933; x=1778608733; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=euKFIAQCeM55RulM535j7KBn6cys8J5H/Q721o26Boo=; b=Jy7mbVa3N//5roee2VcT+lF6Lygqm6oATXFQ2tudn2nOzyN39sJqGnBg7yvZdihUEX UzfOgh0n23xeZrOKNFj+b7hM5iMcCqdcCWlRSPs7W4U9mX1d7TmXyJGDhZ1d7rsnnH14 ngslMGPfsy5DhXoV9VATM899yQUHFJivOYU9g= X-Forwarded-Encrypted: i=1; AFNElJ+aR6Xf6RGj4wiMWI+5jN2fWBEfzbP1pVY01xmIXuMEK6dBQBOIwVezGTnQ5Lq5pKNhSmY6Xr45Y3+qVTE=@vger.kernel.org X-Received: by 2002:a05:7022:238f:b0:127:3f2a:af21 with SMTP id a92af1059eb24-131852d9084mr151520c88.15.1778003932564; Tue, 05 May 2026 10:58:52 -0700 (PDT) X-Received: by 2002:a05:7022:238f:b0:127:3f2a:af21 with SMTP id a92af1059eb24-131852d9084mr151495c88.15.1778003931997; Tue, 05 May 2026 10:58:51 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ee3889d634sm25912919eec.3.2026.05.05.10.58.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 May 2026 10:58:51 -0700 (PDT) Message-ID: Date: Tue, 5 May 2026 10:58:49 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] PCI: brcmstb: Assign pcie->gen from pcie_get_link_speed() To: Bjorn Helgaas Cc: Hans Zhang <18255117159@163.com>, linux-pci@vger.kernel.org, Dom Cobley , Phil Elwell , Jim Quinlan , Broadcom internal kernel review list , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list References: <20260505160144.GA732689@bhelgaas> Content-Language: en-US, fr-FR From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20260505160144.GA732689@bhelgaas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 5/5/26 09:01, Bjorn Helgaas wrote: > On Mon, May 04, 2026 at 04:46:03PM -0700, Florian Fainelli wrote: >> On 5/4/26 10:26, Hans Zhang wrote: >>> On 5/5/26 00:58, Florian Fainelli wrote: >>>> On 5/2/26 04:40, Bjorn Helgaas wrote: >>>>> On Fri, May 01, 2026 at 01:24:38PM -0700, Florian Fainelli wrote: >>>>>> After commit 03f920936977 ("PCI: controller: Validate max-link-speed"), >>>>>> pcie->gen stopped being assigned and as a result the established PCIe >>>>>> link would stop supporting Gen3 speeds on 2712 since pcie->gen is used >>>>>> to populate LnkCntl2 and LnkCap in brcm_pcie_set_gen(). >>>>>> >>>>>> Link: https://github.com/raspberrypi/linux/issues/7343 >>>>>> Reported-by: Dom Cobley >>>>>> Reported-by: Phil Elwell >>>>>> Fixes: 03f920936977 ("PCI: controller: Validate max-link-speed") >>>>>> Signed-off-by: Florian Fainelli >>>>>> --- >>>>>>   drivers/pci/controller/pcie-brcmstb.c | 3 +-- >>>>>>   1 file changed, 1 insertion(+), 2 deletions(-) >>>>>> >>>>>> diff --git a/drivers/pci/controller/pcie-brcmstb.c >>>>>> b/drivers/pci/ controller/pcie-brcmstb.c >>>>>> index 714bcab97b60..6138fc4bc064 100644 >>>>>> --- a/drivers/pci/controller/pcie-brcmstb.c >>>>>> +++ b/drivers/pci/controller/pcie-brcmstb.c >>>>>> @@ -2072,8 +2072,7 @@ static int brcm_pcie_probe(struct >>>>>> platform_device *pdev) >>>>>>           return PTR_ERR(pcie->clk); >>>>>>       ret = of_pci_get_max_link_speed(np); >>>>>> -    if (pcie_get_link_speed(ret) == PCI_SPEED_UNKNOWN) >>>>>> -        pcie->gen = 0; >>>>>> +    pcie->gen = pcie_get_link_speed(ret); >>>>> >>>>> Take a look at https://sashiko.dev/#/ >>>>> patchset/20260501202438.376033-1- >>>>> florian.fainelli%40broadcom.com >>>>> >>>>> The notes at https://github.com/raspberrypi/linux/issues/7343 assumed >>>>> PCI_SPEED_UNKNOWN was 0, but in fact it is 0xff, which means you might >>>>> want the more defensive patch instead. >>>>> >>>>> I'll be happy to replace what's on pci/for-linus if so. >>>> >>>> I am starting to think a revert is the simplest path forward, it's >>>> not clear what pcie_get_link_speed() brings to the table honestly. >>> >>> The pcie_get_link_speed function is designed to prevent other Root Port >>> drivers from accessing the array pcie_link_speed out of bounds. >> >> Yes, so that's useful in the first hunk of your commit where we were >> printing the link speed without checking that the 'max-link-speed' would be >> bounds check, however it is not really useful for assigning to pcie->gen in >> our case, so I would prefer the second option: >> >> ret = of_pci_get_max_link_speed(np); >> - if (pcie_get_link_speed(ret) == PCI_SPEED_UNKNOWN) >> - pcie->gen = 0; >> + pcie->gen = (ret < 0) ? 0 : ret; > > The point of this validation is to make sure we don't program the > brcmstb hardware with something it doesn't support. > > of_pci_get_max_link_speed() only returns an error (ret < 0) if DT > didn't contain a 'max-link-speed' property. That doesn't tell us > anything about what brcmstb devices support. > > I think this test should be something like what advk_pcie_probe() or > rockchip_pcie_parse_dt() do. If of_pci_get_max_link_speed() fails or > returns something not supported by the hardware, they default to the > fastest speed known to be supported. Doing that could be challenging because it varies on a per-controller instance on some chips like 2712, this would also be a behavioral difference compared to today where the driver resorts to HW-defaults if the property is not specified. There is also another aspect we have ignored which is that don't currently support anything beyond Gen3 at this point, but this is not enforced. Let me cook another patch. -- Florian