From: "Li, Aubrey" <aubrey.li@linux.intel.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
mingo@redhat.com, Peter Zijlstra <peterz@infradead.org>,
"H. Peter Anvin" <hpa@zytor.com>,
ak@linux.intel.com, tim.c.chen@linux.intel.com,
dave.hansen@intel.com, arjan@linux.intel.com,
aubrey.li@intel.com, LKML <linux-kernel@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v13 1/3] /proc/pid/status: Add support for architecture specific output
Date: Mon, 8 Apr 2019 08:45:28 +0800 [thread overview]
Message-ID: <d1931260-cdae-8270-80ad-080cf103789a@linux.intel.com> (raw)
In-Reply-To: <20190407154622.GA16004@avx2>
On 2019/4/7 23:46, Alexey Dobriyan wrote:
> On Sun, Apr 07, 2019 at 09:02:38PM +0800, Li, Aubrey wrote:
>> On 2019/4/7 5:41, Alexey Dobriyan wrote:
>>> On Fri, Apr 05, 2019 at 09:32:35PM +0200, Thomas Gleixner wrote:
>>>>> +/* Add support for architecture specific output in /proc/pid/status */
>>>>> +extern void arch_proc_pid_status(struct seq_file *m, struct task_struct *task);
>>> ^^^^^^
>>>
>>> Unnecessary extern.
>>>
>> The linkage is default extern, but with this functions and variables
>> can be treated the same way.
>>
>> Is it mandatory not to use it explicitly? ./script/checkpatch.pl did
>> not report this.
>
> "extern" is only necessary for variables. For prototypes, it is more typing
> and more characters on the screen.
>
> checkpatch.pl doesn't report it because opening floodgates is not the plan.
>
> Yours,
> Extern Police.
>
No problem, Mr. Police, I can remove it in the next version.
Thanks,
-Aubrey
next prev parent reply other threads:[~2019-04-08 0:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-24 4:43 [PATCH v13 1/3] /proc/pid/status: Add support for architecture specific output Aubrey Li
2019-02-24 4:43 ` [PATCH v13 2/3] x86,/proc/pid/status: Add AVX-512 usage elapsed time Aubrey Li
2019-04-05 20:27 ` Jann Horn
2019-04-06 15:41 ` Li, Aubrey
2019-02-24 4:44 ` [PATCH v13 3/3] Documentation/filesystems/proc.txt: add AVX512_elapsed_ms Aubrey Li
2019-04-05 19:32 ` [PATCH v13 1/3] /proc/pid/status: Add support for architecture specific output Thomas Gleixner
2019-04-06 21:41 ` Alexey Dobriyan
2019-04-07 13:02 ` Li, Aubrey
2019-04-07 15:46 ` Alexey Dobriyan
2019-04-08 0:45 ` Li, Aubrey [this message]
2019-04-07 17:34 ` Andy Lutomirski
2019-04-08 0:38 ` Li, Aubrey
2019-04-08 1:52 ` Andy Lutomirski
2019-04-08 2:33 ` Li, Aubrey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1931260-cdae-8270-80ad-080cf103789a@linux.intel.com \
--to=aubrey.li@linux.intel.com \
--cc=adobriyan@gmail.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=aubrey.li@intel.com \
--cc=dave.hansen@intel.com \
--cc=hpa@zytor.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox