From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F187C10F0E for ; Mon, 8 Apr 2019 00:45:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6559A21738 for ; Mon, 8 Apr 2019 00:45:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726513AbfDHApd (ORCPT ); Sun, 7 Apr 2019 20:45:33 -0400 Received: from mga05.intel.com ([192.55.52.43]:32263 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726352AbfDHApc (ORCPT ); Sun, 7 Apr 2019 20:45:32 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Apr 2019 17:45:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,323,1549958400"; d="scan'208";a="162258626" Received: from cli6-desk1.ccr.corp.intel.com (HELO [10.239.161.118]) ([10.239.161.118]) by fmsmga001.fm.intel.com with ESMTP; 07 Apr 2019 17:45:30 -0700 Subject: Re: [PATCH v13 1/3] /proc/pid/status: Add support for architecture specific output To: Alexey Dobriyan Cc: Thomas Gleixner , mingo@redhat.com, Peter Zijlstra , "H. Peter Anvin" , ak@linux.intel.com, tim.c.chen@linux.intel.com, dave.hansen@intel.com, arjan@linux.intel.com, aubrey.li@intel.com, LKML , Linux API , Andrew Morton References: <20190224044400.34975-1-aubrey.li@linux.intel.com> <20190406214143.GA21551@avx2> <7cd8fa2d-301a-5c96-ce3d-3dc373a5d8f5@linux.intel.com> <20190407154622.GA16004@avx2> From: "Li, Aubrey" Message-ID: Date: Mon, 8 Apr 2019 08:45:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20190407154622.GA16004@avx2> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/4/7 23:46, Alexey Dobriyan wrote: > On Sun, Apr 07, 2019 at 09:02:38PM +0800, Li, Aubrey wrote: >> On 2019/4/7 5:41, Alexey Dobriyan wrote: >>> On Fri, Apr 05, 2019 at 09:32:35PM +0200, Thomas Gleixner wrote: >>>>> +/* Add support for architecture specific output in /proc/pid/status */ >>>>> +extern void arch_proc_pid_status(struct seq_file *m, struct task_struct *task); >>> ^^^^^^ >>> >>> Unnecessary extern. >>> >> The linkage is default extern, but with this functions and variables >> can be treated the same way. >> >> Is it mandatory not to use it explicitly? ./script/checkpatch.pl did >> not report this. > > "extern" is only necessary for variables. For prototypes, it is more typing > and more characters on the screen. > > checkpatch.pl doesn't report it because opening floodgates is not the plan. > > Yours, > Extern Police. > No problem, Mr. Police, I can remove it in the next version. Thanks, -Aubrey