Re: [PATCH 19/24] arm64: dts: qcom: glymur: Add support for PCIe5

Dmitry Baryshkov
2025-10-11T15:58:07Z

On Sat, Oct 11, 2025 at 02:43:14PM +0300, Abel Vesa wrote:
> On 25-10-10 00:08:31, Qiang Yu wrote:
> > On Wed, Oct 08, 2025 at 04:36:59PM +0300, Abel Vesa wrote:
> > > On 25-09-25 12:02:27, Pankaj Patil wrote:
> > > > From: Prudhvi Yarlagadda <quic_pyarlaga@quicinc.com>
> > > >
> > > > Describe PCIe5 controller and PHY. Also add required system resources like
> > > > regulators, clocks, interrupts and registers configuration for PCIe5.
> > > >
> > > > Signed-off-by: Prudhvi Yarlagadda <quic_pyarlaga@quicinc.com>
> > > > Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
> > > > Signed-off-by: Pankaj Patil <pankaj.patil@oss.qualcomm.com>
> > > > ---
> > > > arch/arm64/boot/dts/qcom/glymur.dtsi | 208 ++++++++++++++++++++++++++++++++++-
> > > > 1 file changed, 207 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi
> > > > index e6e001485747785fd29c606773cba7793bbd2a5c..17a07d33b9396dba00e61a3b4260fa1a535600f2 100644
> > > > --- a/arch/arm64/boot/dts/qcom/glymur.dtsi
> > > > +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi
> > > > @@ -951,7 +951,7 @@ gcc: clock-controller@100000 {
> > > > <0>,
> > > > <0>,
> > > > <0>,
> > > > - <0>;
> > > > + <&pcie5_phy>;
> > > > #clock-cells = <1>;
> > > > #reset-cells = <1>;
> > > > #power-domain-cells = <1>;
> > > > @@ -2511,6 +2511,212 @@ pcie_west_slv_noc: interconnect@1920000 {
> > > > #interconnect-cells = <2>;
> > > > };
> > > >
> > > > + pcie5: pci@1b40000 {
> > > > + device_type = "pci";
> > > > + compatible = "qcom,glymur-pcie", "qcom,pcie-x1e80100";
> > >
> > > The first compatible is definitely "qcom,pcie-glymur".
> >
> > According to Documentation/devicetree/bindings/arm/qcom-soc.yaml
> > the preferred order is qcom,socname-ipblock.
>
> Fair enough.
>
> Now I wonder what happened when we added the one for x1e80100.

Our PCIe hosts mostly follow the legacy approach and nobody wanted to
change it up to now.

--
With best wishes
Dmitry