Re: [PATCH 07/24] arm64: dts: qcom: glymur: Enable cpu dvfs for CPU scaling

Krzysztof Kozlowski
2025-09-25T08:06:48Z

On Thu, 25 Sept 2025 at 15:33, Pankaj Patil
<pankaj.patil@oss.qualcomm.com> wrote:
>
> From: Taniya Das <taniya.das@oss.qualcomm.com>
>
> Add sram and scmi nodes required to have a functional cpu dvfs
> on Glymur SoCs.
>
> Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
> Signed-off-by: Taniya Das <taniya.das@qualcomm.com>
> Signed-off-by: Pankaj Patil <pankaj.patil@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/glymur.dtsi | 87 +++++++++++++++++++++---------------
> 1 file changed, 51 insertions(+), 36 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi
> index ae013c64e096b7c90c0aa4cfc50f078a85518acb..d924b4778fd37af8fe7b0bceca466dee73269481 100644
> --- a/arch/arm64/boot/dts/qcom/glymur.dtsi
> +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi
> @@ -46,8 +46,8 @@ cpu0: cpu0@0 {
> compatible = "qcom,oryon";
> reg = <0x0 0x0>;
> enable-method = "psci";
> - power-domains = <&CPU_PD0>;
> - power-domain-names = "psci";

NAK

You just added these lines!

This is some ridiculous way of splitting patches. Sending wrong commit
and then fixing it immediately.

Same as Kaanapali, same broken process which year ago and two years
ago I was already commenting on. You are repeating the same mistakes,
sending wrong code and patches which are unnecessarily difficult to
review. And we discussed exactly this already!

Best regards,
Krzysztof