Re: [PATCH 17/24] arm64: dts: qcom: glymur-crd: Avoid RTC probe failure

Krzysztof Kozlowski
2025-10-06T14:32:46Z

On 01/10/2025 21:23, Kamal Wadhwa wrote:
> Hi Krzysztof,
>
> On Thu, Sep 25, 2025 at 1:41 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On Thu, 25 Sept 2025 at 15:34, Pankaj Patil
>> <pankaj.patil@oss.qualcomm.com> wrote:
>>>
>>> From: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>
>>>
>>> On Glymur boards, the RTC alarm interrupts are routed to SOCCP
>>> subsystems and are not available to APPS. This can cause the
>>> RTC probe failure as the RTC IRQ registration will fail in
>>> probe.
>>>
>>> Fix this issue by adding `no-alarm` property in the RTC DT
>>> node. This will skip the RTC alarm irq registration and
>>> the RTC probe will return success.
>>
>>
>> This is ridiculous. You just added glymur CRD and you claim now that
>> it's broken and you need to fix it. So just fix that commit!
>
> I'm afraid, but this is an actual limitation we have for Glymur
> (compared to Kaanapali).
> The RTC is part of the pmk8850.dtsi that is common between Kaanapali and
> Glymur. On Glymur (unlike Kaanapali) the APPS processor does *not* have the RTC
> IRQ permission for the RTC peripheral.
>
> So we need this extra change in Glymur explicitly as a workaround to
> make RTC register
> properly.
>
> But sure, we can squash this into the main DT patch, if you think this
> is not a limitation
> that needs to be highlighted in a separate patch.
>
>>
>> This is a gross misinterpretation of splitting patchset, some twisted
>> LWN stats work.
>
> Sorry for this. It was not intentional (definitely not for LWN stats),
> mainly this happened
> because this is how individual driver owners/teams internally added
> their patches. So

You upstream all this, so YOU should organize this work for upstream,
not just copy-paste what internal owners/teams did.

Upstream community does not care about owners/teams concept. You must
send logically consistent and organized in sane way patchset, which
means squashing all such stuff so in new code you will never use word
"fix" for something you just added.

Best regards,
Krzysztof