Re: [PATCH 23/24] arm64: dts: qcom: glymur: Add USB support

Konrad Dybcio
2025-09-25T11:06:44Z

On 9/25/25 8:32 AM, Pankaj Patil wrote:
> From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>
> The Glymur USB system contains 3 USB type C ports, and 1 USB multiport
> controller. This encompasses 5 SS USB QMP PHYs (3 combo and 2 uni) and 5
> M31 eUSB2 PHYs. The controllers are SNPS DWC3 based, and will use the
> flattened DWC3 QCOM design.
>
> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> Signed-off-by: Pankaj Patil <pankaj.patil@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/glymur-crd.dts | 243 ++++++++++++++
> arch/arm64/boot/dts/qcom/glymur.dtsi | 569 ++++++++++++++++++++++++++++++++

Please split this into two commits

[...]

> +&i2c5 {
> + status = "ok";

"okay" is preferred:

$ rg '"ok"' arch | wc -l
6

$ rg '"okay"' arch | wc -l
33019

on a random recent next tree

'status' is also expected to come as the last property (but still before
subnodes)

[...]

> +&usb_1_ss0 {
> + dr_mode = "otg";
> + usb-role-switch;

usb-role-switch should be in the SoC DT, and I think "otg" is the
default dr_mode

[...]

> + usb_1_ss0: usb@a600000 {

the nodes should be sorted by unit address

Konrad