Re: [PATCH 18/24] arm64: dts: qcom: glymur: Add PMIC glink node

Kamal Wadhwa
2025-11-03T10:27:00Z

On Wed, Oct 08, 2025 at 05:25:39PM +0530, Pankaj Patil wrote:
> On 9/25/2025 4:02 PM, Konrad Dybcio wrote:
> > On 9/25/25 8:32 AM, Pankaj Patil wrote:
> >> From: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>
> >>
> >> Add the pmic glink node with connectors.
> >>
> >> Signed-off-by: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>
> >> Signed-off-by: Pankaj Patil <pankaj.patil@oss.qualcomm.com>
> >> ---
> >> arch/arm64/boot/dts/qcom/glymur-crd.dts | 28 ++++++++++++++++++++++++++++
> >> 1 file changed, 28 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dts b/arch/arm64/boot/dts/qcom/glymur-crd.dts
> >> index b04c0ed28468620673237fffb4013adacc7ef7ba..3f94bdf8b3ccfdff182005d67b8b3f84f956a430 100644
> >> --- a/arch/arm64/boot/dts/qcom/glymur-crd.dts
> >> +++ b/arch/arm64/boot/dts/qcom/glymur-crd.dts
> >> @@ -79,6 +79,34 @@ key-volume-up {
> >> wakeup-source;
> >> };
> >> };
> >> +
> >> + pmic-glink {
> >> + compatible = "qcom,sm8550-pmic-glink",
> > You *must* include a glymur compatible
> >
> >> + "qcom,pmic-glink";
> > Are you sure this is still compatible with 8550 after this
> > series landed?
> >
> > https://lore.kernel.org/linux-arm-msm/20250917-qcom_battmgr_update-v5-0-270ade9ffe13@oss.qualcomm.com/

Sorry for late reply, earlier when we were sending this series our understanding
was that we only need to support for usb shell, and anyway the device was on the
debug board so this feature(battery/charging) was not tested.

However, after testing i found that the power supplies are getting registered
properly however the data is not coming as expected. we are working to fix this
internally from the firmware guys.

Is it ok to just enable the UCSI (usb shell) and enable the battery feature
later?

> >
> > Konrad
>
> I'll check and add a glymur compatible in next revision

NOTE: glymur dt bindings with the compatible change has been posted.
https://lore.kernel.org/all/20251027212250.3847537-1-anjelique.melendez@oss.qualcomm.com/

>