Re: [PATCH 04/24] arm64: dts: qcom: glymur: Add QUPv3 configuration for serial engines

Krzysztof Kozlowski
2025-10-12T02:46:08Z

On 11/10/2025 13:11, Abel Vesa wrote:
> On 25-10-11 14:06:44, Abel Vesa wrote:
>> On 25-09-25 12:02:12, Pankaj Patil wrote:
>>> From: Jyothi Kumar Seerapu <jyothi.seerapu@oss.qualcomm.com>
>>> + dma-channels = <16>;
>>> + dma-channel-mask = <0x3f>;
>>> + #dma-cells = <3>;
>>> + iommus = <&apps_smmu 0xd76 0x0>;
>>> + status = "ok";
>>
>> s/ok/okay/
>>
>> Everywhere actually.
>>
>
> Actually no. Maybe drop entirely like Konrad already suggested.
>
> But then everywhere else you do "ok" please replace with "okay",
> otherwise dtbs_check complains.

I actually wonder how this passed any dtbs tests... or it wasn't tested
at all?

Best regards,
Krzysztof