Re: [PATCH 23/24] arm64: dts: qcom: glymur: Add USB support

Abel Vesa
2025-11-03T17:00:26Z

On 25-09-25 12:02:31, Pankaj Patil wrote:
> From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>
> The Glymur USB system contains 3 USB type C ports, and 1 USB multiport
> controller. This encompasses 5 SS USB QMP PHYs (3 combo and 2 uni) and 5
> M31 eUSB2 PHYs. The controllers are SNPS DWC3 based, and will use the
> flattened DWC3 QCOM design.
>
> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> Signed-off-by: Pankaj Patil <pankaj.patil@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/glymur-crd.dts | 243 ++++++++++++++
> arch/arm64/boot/dts/qcom/glymur.dtsi | 569 ++++++++++++++++++++++++++++++++
> 2 files changed, 812 insertions(+)
>

[...]

> diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi
> index 8a563d55bdd4902222039946dd75eaf4d3a4895b..c48d3a70820e551822c5322761528159da127ca6 100644
> --- a/arch/arm64/boot/dts/qcom/glymur.dtsi
> +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi

[...]

> +
> + usb_1_ss1_hsphy: phy@fdd000 {
> + compatible = "qcom,glymur-m31-eusb2-phy",
> + "qcom,sm8750-m31-eusb2-phy";
> +
> + reg = <0 0x00fdd000 0 0x29c>;
> + #phy-cells = <0>;
> +
> + resets = <&gcc GCC_QUSB2PHY_SEC_BCR>;
> +
> + status = "disabled";
> + };
> +
> + usb_1_ss1_qmpphy: phy@fde000 {
> + compatible = "qcom,glymur-qmp-usb3-dp-phy";
> + reg = <0 0x00fde000 0 0x8000>;
> +
> + clocks = <&gcc GCC_USB3_SEC_PHY_AUX_CLK>,
> + <&rpmhcc RPMH_CXO_CLK>,
> + <&gcc GCC_USB3_SEC_PHY_COM_AUX_CLK>,
> + <&gcc GCC_USB3_SEC_PHY_PIPE_CLK>,
> + <&tcsrcc TCSR_USB4_1_CLKREF_EN>;

So I think this clock is actually needed, but I think it should
replace the RPMG_CXO_CLK above and then no need for "clkref" below.

The reason this works is because the bi_tcxo is already the parent of
this ref clock.

I did something similar on x1e just now:
https://lore.kernel.org/all/20251103-dts-qcom-x1e80100-fix-combo-ref-clks-v1-1-f395ec3cb7e8@linaro.org/

Still don't get why the SS0 doesn't have/need such a ref clock.
On both hamoa and glymur.