Re: [PATCH 14/24] arm64: dts: qcom: Update the pmh0110.dtsi for Glymur

Krzysztof Kozlowski
2025-09-25T08:09:06Z

On Thu, 25 Sept 2025 at 15:34, Pankaj Patil
<pankaj.patil@oss.qualcomm.com> wrote:
>
> From: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>
>
> Add multiple instance of PMH0110 DT node, one for each assigned
> SID for this PMIC on the spmi_bus0 and spmi_bus1 on the Glymur
> CRD.
>
> Take care to avoid compilation issue with the existing nodes by
> gaurding each PMH0110 nodes with `#ifdef` for its corresponding
> SID macro. So that only the nodes which have the their SID macro
> defined are the only ones picked for compilation.
>
> Signed-off-by: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>
> Signed-off-by: Pankaj Patil <pankaj.patil@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/pmh0110.dtsi | 66 ++++++++++++++++++++++++++++++++++-
> 1 file changed, 65 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/pmh0110.dtsi b/arch/arm64/boot/dts/qcom/pmh0110.dtsi
> index b99c33cba8860f1852231db33a127646c08c1e23..4a5c66e5c9fbc35cedb67601f4568844dc41fbea 100644
> --- a/arch/arm64/boot/dts/qcom/pmh0110.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmh0110.dtsi
> @@ -7,6 +7,8 @@
> #include <dt-bindings/spmi/spmi.h>
>
> &spmi_bus0 {
> +
> +#ifdef PMH0110_D_E0_SID

NAK

I already explained on IRC in great details why.

Best regards,
Krzysztof