Re: [PATCH 04/24] arm64: dts: qcom: glymur: Add QUPv3 configuration for serial engines

Jyothi Kumar Seerapu
2025-10-15T10:28:38Z

On 9/25/2025 3:48 PM, Konrad Dybcio wrote:
> On 9/25/25 8:32 AM, Pankaj Patil wrote:
>> From: Jyothi Kumar Seerapu <jyothi.seerapu@oss.qualcomm.com>
>>
>> Add device tree support for QUPv3 serial engine protocols on Glymur.
>> Glymur has 24 QUP serial engines across 3 QUP wrappers, each with
>> support of GPI DMA engines.
>>
>> Signed-off-by: Jyothi Kumar Seerapu <jyothi.seerapu@oss.qualcomm.com>
>> Signed-off-by: Pankaj Patil <pankaj.patil@oss.qualcomm.com>
>> ---
>
> [...]
>
>> + gpi_dma2: dma-controller@800000 {
>> + compatible = "qcom,glymur-gpi-dma", "qcom,sm6350-gpi-dma";
>> + reg = <0 0x00800000 0 0x60000>;
>> + interrupts = <GIC_SPI 588 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 589 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 590 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 591 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 592 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 593 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 594 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 595 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 596 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 597 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 598 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 599 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_ESPI 129 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_ESPI 130 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_ESPI 131 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_ESPI 132 IRQ_TYPE_LEVEL_HIGH>;
>> + dma-channels = <16>;
>> + dma-channel-mask = <0x3f>;
>> + #dma-cells = <3>;
>> + iommus = <&apps_smmu 0xd76 0x0>;
>> + status = "ok";
>
> this is implied by default, drop

Hi Konard,

Do you mean we should remove the status property for all QUPs and
GPI_DMAs from the common device tree (SOC) and enable them only in the
board-specific device tree files?

>
>> + };
>> +
>> qupv3_2: geniqup@8c0000 {
>> compatible = "qcom,geni-se-qup";
>> reg = <0x0 0x008c0000 0x0 0x3000>;
>> @@ -718,6 +744,339 @@ qupv3_2: geniqup@8c0000 {
>> #address-cells = <2>;
>> #size-cells = <2>;
>> ranges;
>> + status = "ok";
>
> ditto
>
> (please resolve all occurences)
>
> [...]
>
>> + cnoc_main: interconnect@1500000 {
>> + compatible = "qcom,glymur-cnoc-main";
>> + reg = <0x0 0x01500000 0x0 0x17080>;
>> + qcom,bcm-voters = <&apps_bcm_voter>;
>> + #interconnect-cells = <2>;
>> + };
>> +
>> + config_noc: interconnect@1600000 {
>> + compatible = "qcom,glymur-cnoc-cfg";
>> + reg = <0x0 0x01600000 0x0 0x6600>;
>> + qcom,bcm-voters = <&apps_bcm_voter>;
>> + #interconnect-cells = <2>;
>> + };
>> +
>> + system_noc: interconnect@1680000 {
>> + compatible = "qcom,glymur-system-noc";
>> + reg = <0x0 0x01680000 0x0 0x1c080>;
>> + qcom,bcm-voters = <&apps_bcm_voter>;
>> + #interconnect-cells = <2>;
>> + };
>
> This diff becomes unreadable really fast.. please play with git
> format-patch's --patience option
>
> Konrad