From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AD1F39283C for ; Mon, 29 Jun 2026 05:43:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782711828; cv=none; b=BVdNRkC6AwE4/HrrJlR9RdN5szHUANHoJOKBazwN4sVObmR/DqN7/NFr7wPglUZ7sPXrvxcN2EGrnXDf7o2o/zBPJAhmdsW2PpGz1MumgcIfakdmNipKj7JmZLZenA0oQ57irc9UQqrbB1GJpUPfJaT/hIr2Soq88hKIQcp0NaY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782711828; c=relaxed/simple; bh=on1KTmzWpgeJrxWiu7nt68OzK/d+1DZp/YzGH08CkU0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BSMM3k/mvyeYFzB6X+RXUmre0Fouy3vDbrGWU5ef1uymH4cSlu2tW2chAWH9mZmeYEEJLAdUjqRNgRYDdTIU4z2QW4M42QyZBri+VtbCmWOtThIreHrnAGtR5wCrO2Yc+uiLcyNJWKZGQaFi4aLpwY38KVxvU9SRD2CnhwPIKYw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Kq+/Nm44; arc=none smtp.client-ip=91.218.175.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Kq+/Nm44" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1782711822; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ChdUSWfBkHyeaqar08xzsyHYQg5YpcQ+wmBXfdjD6hA=; b=Kq+/Nm44LhxZ2NPTJMVCvXCFomBtyZXosC2RJ0KUNS8Rvn80gxx2TyT4hoFxbeO+cL6Rdh C82NQ9ZWAIVR0Qzplog6gIgJaDiudbl9assFkE+TVKPW7JlHPbYge2Y2eQ26J4LTpDrIlF a6zvta0eoxODo89xuLNb31UrzmVzj6I= Date: Mon, 29 Jun 2026 13:43:34 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] sched/deadline: Exclude special DL entities from bandwidth moves To: Ingo Molnar , Peter Zijlstra , Juri Lelli Cc: Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak , linux-kernel@vger.kernel.org, Guopeng Zhang , Christian Loehle References: <20260528065324.1303334-1-guopeng.zhang@linux.dev> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Guopeng Zhang In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Hi Peter, Ingo, Gentle ping on this patch. It has received Reviewed-by from Christian and Acked-by from Juri. Do you think it is suitable for the sched/core tree, or is there anything else I should change? Thanks, Guopeng 在 2026/5/28 20:24, Juri Lelli 写道: > Hello! > > On 28/05/26 14:53, Guopeng Zhang wrote: >> From: Guopeng Zhang >> >> SUGOV special DL entities use fake/unused bandwidth. They are already >> excluded from regular DL admission control, affinity admission checks, >> rq bandwidth accounting, and root-domain rebuild accounting. >> >> dl_task_needs_bw_move() misses the same exclusion. As a result, >> set_cpus_allowed_dl() and cpuset attach may treat a special DL entity as >> requiring a root-domain bandwidth move when its affinity mask no longer >> intersects the source root domain. >> >> Return false for special DL entities so root-domain bandwidth move >> accounting follows the rest of the SUGOV special-entity handling. >> >> Signed-off-by: Guopeng Zhang >> --- >> kernel/sched/deadline.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c >> index ddfd6bc63ab1..3653166caa69 100644 >> --- a/kernel/sched/deadline.c >> +++ b/kernel/sched/deadline.c >> @@ -3142,7 +3142,7 @@ static void set_cpus_allowed_dl(struct task_struct *p, >> bool dl_task_needs_bw_move(struct task_struct *p, >> const struct cpumask *new_mask) >> { >> - if (!dl_task(p)) >> + if (!dl_task(p) || dl_entity_is_special(&p->dl)) >> return false; >> >> return !cpumask_intersects(task_rq(p)->rd->span, new_mask); > > Makes sense to me. > > Acked-by: Juri Lelli > > Best, > Juri >