From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 386D53D1ABD for ; Sun, 16 Aug 2026 21:21:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786915273; cv=none; b=oGh6gzodkb16wpO6xCn7sz/yTCQbLtE3DoZ91f89Vzz6Bkjmy1gS/6tPDqxwugx0yi6qJ76P1l6ejS1tlBbj/zXkXArhT7wnx0lGdQpbhsfTY+kYuOcV/R/BuxF+ahSPH6EQlsIBJ5W/W5nhRKI91+UKlaaqeGRRgVsdorwN0Qo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786915273; c=relaxed/simple; bh=SyBzG8tgXnX0VUfUgJmy5OmXu1TW9rOySjd3Fo30FqU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VbFUBIwOsFBggs4VppIQ87phHmm7f1i+BmWbYEkT+Q4P6UXeP3xSG7HJHiW/f9hMuYE3esNdBRXryJ8NDUNNCvnOQSdb+ttYNDlV3uhvF2cqihpO3z6+A52/Uy1Nyzj27IUnsyJ8qNYKQJSPSOBJDjSePTXDux6UEdtwzVgQm88= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jANSKNYH; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jANSKNYH" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-49987fb18c0so13236335e9.3 for ; Sun, 16 Aug 2026 14:21:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786915270; x=1787520070; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JhVr3MmkgG7lZrSEkj9eSOnYjsgd84dLTq7WCL5Ocdg=; b=jANSKNYHzaNAQd/a/DbYPf/c8lwobp2OqyOmzgFts44Zg4JdfOngWv586YzXKwJW1W +BL+pbZukkOgilbUcQ9CWp99oixiSeB4d9frOYxyXNxJKTcb96TR+AgoJYpKNHl5XAmI eXB3Kbx0RxA9hYWEwaSQb+9ORM88SNODs9NkyDAww0N19Un4N/EiWk+DApnBuCiuGkYw jex4IbErPop+n9/rjSqNQ2KkJE62LVwwbqcwl+HhilWVZeAVwUXSspfXw4fQlXcqLhmq phJh4bEatnx/KEv4qbpwOjNsgmDSw7hCZwYNwnKP+9mI/G9FZFIaIX8g8j/T2I7h1+8J MdrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786915270; x=1787520070; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=JhVr3MmkgG7lZrSEkj9eSOnYjsgd84dLTq7WCL5Ocdg=; b=H8htnJiFH1ifOm6YCagKSU1wT/I8dnWKyL/L2RyK4D81S4UzXoPpK+rT8PL2ezBeJD CIvQjmVqUaSEJJPEwnypKB1dDGoaBJnzQ19dnvMk1tIhzDPH5Y5ZtcV+CJCmj5plnT56 OWnFCPHDI0WcsJ1JwXtZ7gGl+2ksaLNw2SfAdedYFqbMJJM4Ngil3tQTn1MSN3QGjYCi 7KgYWnnAasMyWEu0a0rB+IYZG1vXKl4ex3ACn9tiDUILn4TzYga89v2BRQSPf+RVyfVm d+dMyCQGydM6+GY818rjVtnXs9BoWyYeE3p/hHzchlJP6Ebra3F3WbXqB53kUe/mTKaM 3vng== X-Forwarded-Encrypted: i=1; AHgh+Rp6upBo+KvIc2qmjiTBr6gJWhaDe4nPVk1g+aMEwQ/ekwJtT49dcZHC2jFYLyastrF7RkSR2FrNpPISklw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3nIPtVJny2hXJqmoqZkICTrx/pFLhHeBPbEh7Mt3OBnagmIoc iVBqUj3xx+CZ+aR8yeWI5SdYyPK0a3n38oqVl4f4TeV30UM3jvrYYJSI X-Gm-Gg: AR+sD11Zbp62lxMZOflxkdw5jklmmtWOyB20NuurMfPP6e9g6zrxBjRHthhSyPHHrNr b2GuIBABQk5jyHhSK0W7VYilwuegQsmPljQs1a26D2Tgx2nvUlnaXeJyIDQK/aEAtSlUJ404DZx 5ZJH/4TPBakdFfWeYJguM/h6EiLwjXw8cQZNpdOGjzpv0ozA8kunWtGlYmIaIVuy5SGFAEYu121 wyWRGs5UbPVCDcLwoyKrUZNaytamw2Va++JWKTDtO6WJKkx22sqGyIjFambtGPxIDCDDbjiJKCP 1z6lUByDrQRxLDvvYm7GOcCLXGUDLI/w7N8uG7SFCgDPeR6P9OJm0jTiOoTByVQt6NvR9KtcVtz X7qVisAoPLHFj12MdC5+1jJIcYBXirYxKYEGey6SsM/oaztHZ8HUQ2fd1Q/SXYnm3yidEddrXBE 7Pt+yUy+4I9aS3LDVCq1/F2cJe+wp8/qECGUdfXeXKoQYSyoi6doDAB4JbVXkEhp8lPpF+qZryR oQ3FclcferQZvoAmNO/qUEIZzyThEawBMh8pk2yk9G7xprLGlfzf4kL X-Received: by 2002:a05:600c:1f91:b0:497:fecd:5b00 with SMTP id 5b1f17b1804b1-4998797c6dbmr281240785e9.9.1786915270255; Sun, 16 Aug 2026 14:21:10 -0700 (PDT) Received: from [10.128.10.232] (195-23-151-163.net.novis.pt. [195.23.151.163]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499960fef95sm94521045e9.1.2026.08.16.14.21.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Aug 2026 14:21:09 -0700 (PDT) Sender: Julian Braha Message-ID: Date: Sun, 16 Aug 2026 22:21:08 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ASoC: fix unmet dependencies on PPC_BESTCOMM and SND_SOC_AC97_BUS To: Rosen Penev Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, arnd@arndb.de, chancel.liu@nxp.com, jonsmirl@gmail.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260802144855.3596995-1-julianbraha@gmail.com> <999edd39-43d0-4973-96ce-a205283277ff@gmail.com> Content-Language: en-US From: Julian Braha In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 8/16/26 22:11, Rosen Penev wrote: > On Sat, Aug 15, 2026 at 5:01 PM Julian Braha wrote: >> >> Hi Rosen, >> >> On 8/2/26 22:14, Rosen Penev wrote: >>> On Sun, Aug 2, 2026 at 7:49 AM Julian Braha wrote: >>>> >>>> SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA both select >>>> SND_SOC_MPC5200_AC97 without ensuring that its dependency on PPC_BESTCOMM is >>>> met. This causes unmet dependencies such as: >>>> >>>> WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97 >>>> Depends on [n]: SOUND [=m] && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_BESTCOMM [=n] >>>> Selected by [m]: >>>> - SND_MPC52xx_SOC_PCM030 [=m] && SOUND [=m] && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC5200_SIMPLE [=y] >>>> >>>> SND_MPC52xx_SOC_EFIKA also selects SND_SOC_STAC9766 without ensuring its >>>> dependency on SND_SOC_AC97_BUS is met. >>>> >>>> Let's resolve all 3 unmet dependencies by adding the dependencies on >>>> PPC_BESTCOMM where needed, and selecting SND_SOC_AC97_BUS as other, similar >>>> options in this subsystem do. >>>> >>>> These unmet dependency bugs were detected by kconfirm, a static analysis tool >>>> for Kconfig. >>>> >>>> Fixes: a9262c4fd404 ("ASoC: Support for AC97 on Phytec pmc030 base board.") >>>> Fixes: 6ffee43ecf8b ("ASoC: Fabric bindings for STAC9766 on the Efika") >>>> Signed-off-by: Julian Braha >>>> --- >>>> sound/soc/fsl/Kconfig | 4 +++- >>>> 1 file changed, 3 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig >>>> index 8ae59c094878..a5d7cf534391 100644 >>>> --- a/sound/soc/fsl/Kconfig >>>> +++ b/sound/soc/fsl/Kconfig >>>> @@ -243,7 +243,7 @@ config SND_SOC_MPC5200_AC97 >>>> >>>> config SND_MPC52xx_SOC_PCM030 >>>> tristate "SoC AC97 Audio support for Phytec pcm030 and WM9712" >>>> - depends on PPC_MPC5200_SIMPLE >>>> + depends on PPC_BESTCOMM >>>> select SND_SOC_MPC5200_AC97 >>>> select SND_SOC_WM9712 >>>> help >>>> @@ -253,6 +253,8 @@ config SND_MPC52xx_SOC_PCM030 >>>> config SND_MPC52xx_SOC_EFIKA >>>> tristate "SoC AC97 Audio support for bbplan Efika and STAC9766" >>>> depends on PPC_EFIKA >>>> + depends on PPC_BESTCOMM >>> does this really depend on PPC_BESTCOMM? >> >> Yes, BestComm is the co-processor found on Freescale MPC5200. > Just took a look at this. > > --- a/sound/soc/fsl/efika-audio-fabric.c > +++ b/sound/soc/fsl/efika-audio-fabric.c > @@ -22,8 +22,6 @@ > #include > #include > > -#include "mpc5200_dma.h" > - > #define DRV_NAME "efika-audio-fabric" > > SND_SOC_DAILINK_DEFS(analog, > > compiles. That header indeed references bestcom stuff, but I don't see > the driver doing so. >> >> - Julian Braha Ahh, nice catch! I'll send a v2 soon. - Julian Braha