From: Florian Fainelli <f.fainelli@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
Florian Klink <flokli@flokli.de>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Stefan Wahren <wahrenst@gmx.net>
Subject: Re: [PATCH] ARM: dts: bcm283x: Fix hdmi hpd-gpio pin
Date: Mon, 15 Jul 2024 16:20:09 -0700 [thread overview]
Message-ID: <d1e402f0-49dd-4b83-8cf6-e2b15e9f7300@gmail.com> (raw)
In-Reply-To: <f178aa92-d91c-406d-9fea-1021bfb99f55@gmail.com>
On 7/15/24 16:19, Florian Fainelli wrote:
> +Stefan,
With the correct email this time...
>
> On 7/15/24 16:03, Florian Klink wrote:
>> HDMI_HPD_N_1V8 is connected to GPIO pin 0, not 1.
>>
>> This fixes HDMI hotplug/output detection.
>>
>> See https://datasheets.raspberrypi.com/cm/cm3-schematics.pdf
>>
>> Signed-off-by: Florian Klink <flokli@flokli.de>
>
> Assuming Stefan is OK wit the change, I will apply this along with a:
>
> Fixes: a54fe8a6cf66 ("ARM: dts: add Raspberry Pi Compute Module 3 and IO
> board")
>
>> ---
>> arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts
>> b/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts
>> index 72d26d130efa..85f54fa595aa 100644
>> --- a/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts
>> +++ b/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts
>> @@ -77,7 +77,7 @@ &gpio {
>> };
>> &hdmi {
>> - hpd-gpios = <&expgpio 1 GPIO_ACTIVE_LOW>;
>> + hpd-gpios = <&expgpio 0 GPIO_ACTIVE_LOW>;
>> power-domains = <&power RPI_POWER_DOMAIN_HDMI>;
>> status = "okay";
>> };
>
--
Florian
next prev parent reply other threads:[~2024-07-15 23:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 23:03 [PATCH] ARM: dts: bcm283x: Fix hdmi hpd-gpio pin Florian Klink
2024-07-15 23:19 ` Florian Fainelli
2024-07-15 23:20 ` Florian Fainelli [this message]
2024-07-16 5:30 ` Stefan Wahren
2024-07-16 17:08 ` Florian Klink
2024-07-16 17:22 ` Florian Fainelli
2024-07-16 17:47 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1e402f0-49dd-4b83-8cf6-e2b15e9f7300@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=flokli@flokli.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox