From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EA3E33D6ED for ; Sat, 9 May 2026 23:53:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778370790; cv=none; b=KRDgxAzZapRT0jxwmX4kVIEJnY9KyimjPsAZ05KtM1FgKefWd3s9Lwq5oUQrh24W2lxIhZBt3ceh7eGxTZp8gdPmCuKGVZNGDdRmKxDtJmy03oyAl85X0fOFxpjgI5pXpgarHuAtodL8CxAnMScO/vdOcViZWVPSKdntmDZCdhY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778370790; c=relaxed/simple; bh=CQLoY+LY/NNDrILnxsCehh8h8uCiW0ClxhX+PDVHPM0=; h=Message-ID:Date:MIME-Version:To:Cc:From:Subject:Content-Type; b=OkcQPB/YpR2SKVODzZ6zHbNM/NABvYNxSa/vbILONWQDCuFlm5MMuP2ihfHHqfrSuJHF3LY81csEgXblV3SQG7K+vLogjQXgUpmJrIT5MEk13+oDmlQnxROOLnawidDBmivpSrin5nMCkLAh9QmcCPLVbiDYWtqOKBvdaV58vww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=tF7VWvoa; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tF7VWvoa" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4852b81c73aso29046395e9.3 for ; Sat, 09 May 2026 16:53:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778370787; x=1778975587; darn=vger.kernel.org; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=Z+++qTKQ/UpP+Bja1ypEFmkBeIFNHUF32EtoWxZo7MA=; b=tF7VWvoaCKW8ysjHqFV3XrMopOXKRX5xm2BLv+mMbSjwSZB8xFsvFZnRt6XhpOTbw+ yZhoLwJ7r3i1X65FgUlpnjS0S9qQrJUbcXO8i3w8CrD0NLPYgDo1VzPYHY2QIfqXxkLN uCy804A+KgqIerwTHp7Z3tdc0E1gkYSVHgWRucdSReHtbfCIadFmw7qF3FfYfGaW7kyN 6pMcxxkTODMfNFyh3jlOMIeFnLKhBo/bCjkEOC7pyU1LnFqVJplcv50QSXFuWWAnvSvA tLpcc/QzgHF8N/QqbveAsi6Cws1HsMEU+rvq307xLoxAYX7ygh0nUgCeZUM9uzk5fkxz /6Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778370787; x=1778975587; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Z+++qTKQ/UpP+Bja1ypEFmkBeIFNHUF32EtoWxZo7MA=; b=S4B1QsTcLIBKjI74/z5L9ML9I5wmRde8u/cy6twB5JhOVem+moEmJ9Ojj2PF8BuL4V D2HVbPdryYRkyet+oneCaUs8xPAwpwMNTffy/jNt9cMmRyC+SARNFn5olpo50tim9J6T XhJqcgu9l1eTdNEIS1o2gkJFZSwhuZ1HU5UAWXJE5cDOdAJyhcifOvhMZ9p45Nyurtuy TVmayYdD8o+eOmmjzm6tdQPc8JbieRZDfNSOMOa7oSioVqtXguOf6uzNF5upxqVqP7Fr XqPpN/RiFDhNq+DogpTho3lyyvdywVGNu5/QFPltPGcDHFeT6B/CHq7pagwicjzyGyQ9 Nltg== X-Forwarded-Encrypted: i=1; AFNElJ/0hPJ2o5yxCVpExOKDmUM9mtCfcyZJo2IGXV9MHCYI76zwLQtavS8Vh5H5VloPtkfyimFmOCJpTdUtGyI=@vger.kernel.org X-Gm-Message-State: AOJu0YzVlApDG4Ix4S3Em5fKxejPERujBERSComxfr6VJCax2vfeNOJr 04ciDWSeNmrv9hPFhpEtIt45OGRoJS0o+2NpKrW2H/i5zXh6TpS5Ozz7 X-Gm-Gg: Acq92OEdrUErh3BA2KyL8IkPoPznOxW+/U5tjWq8LSnOyQGVlzSPVlixyu4K8tvJWR1 Z/CfkQ80+RUoB18+iLz1K6X5iVfpgljzMfHUR3NyPZgw5GYc/v6ClvO74CML6Tlpek+jJZJsf56 s9a2P/gekEvcuIwACrpOWOkNpDl3M7SUZyYwEur70TPFYsvgwODNAOk0rIhnsTySPIKT5hLkf55 ZsMNuM+NrejvtcBpiNfiLJKFWbu5fd+pLU7Ld+m5fLaIqIVG7kcF44uJm/F+nj6NWkxOUtM3pQO sKklhPFLGZwfz5PMrwJ3HvDSEvcGFTVJ44sUQiRseuiFzvfoFhw8mzLdYWXbEYz20OjfKAss34l CjL2xM2cafAurzqlkrUPhks5yocoR+A4EgfOOk/VgDCF8CJZUjA7ZRh9G7QAnOfcMganzGFiqKa XpnUVsd/JEI1c3cZjjxRXir3RX3kH+ADl66OVHnVeN2Dqjjcxbbc1qtVM2XvNhP+Zd7CwY1xswT Jc8g59J6UbyXQ9N19uuYLNv6zniyg== X-Received: by 2002:a05:600c:a111:b0:488:79a3:f04c with SMTP id 5b1f17b1804b1-48e51f46d1bmr208379425e9.27.1778370787264; Sat, 09 May 2026 16:53:07 -0700 (PDT) Received: from ?IPV6:2a02:2f04:a405:b300:e2a1:1a24:245d:ce04? ([2a02:2f04:a405:b300:e2a1:1a24:245d:ce04]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4548e4bb87bsm14403001f8f.2.2026.05.09.16.53.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 May 2026 16:53:06 -0700 (PDT) Message-ID: Date: Sun, 10 May 2026 02:53:04 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org Cc: almaz.alexandrovich@paragon-software.com, m.brodschi@gmail.com From: Mihai Brodschi Subject: [PATCH v2] ntfs3: Allocate iomap inline_data using alloc_page Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit This fixes a BUG reported in iomap_write_end_inline: iomap_inline_data_valid checks that the inline_data fits within a page. If the inline_data is allocated with kmemdup there's no guarantee that it's page-aligned, so the check sometimes fails. Allocate it with alloc_page to ensure it's page-aligned. Closes: https://bugzilla.kernel.org/show_bug.cgi?id=221446 Signed-off-by: Mihai Brodschi Fixes: 099ef9a ("fs/ntfs3: implement iomap-based file operations") --- V2: fix mail formatting fs/ntfs3/attrib.c | 9 ++++++--- fs/ntfs3/inode.c | 4 ++-- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/fs/ntfs3/attrib.c b/fs/ntfs3/attrib.c index e61c5bf7e27e..f72848d077b9 100644 --- a/fs/ntfs3/attrib.c +++ b/fs/ntfs3/attrib.c @@ -1042,10 +1042,13 @@ int attr_data_get_block_locked(struct ntfs_inode *ni, CLST vcn, CLST clen, *lcn = RESIDENT_LCN; *len = data_size; if (res && data_size) { - *res = kmemdup(resident_data(attr_b), data_size, - GFP_KERNEL); - if (!*res) + void *page = alloc_page(GFP_KERNEL); + if (!page) { err = -ENOMEM; + } else { + *res = page_address(page); + memcpy(*res, resident_data(attr_b), data_size); + } } goto out; } diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c index 42af1abe17f8..031f85fd53d4 100644 --- a/fs/ntfs3/inode.c +++ b/fs/ntfs3/inode.c @@ -801,7 +801,7 @@ static int ntfs_iomap_begin(struct inode *inode, loff_t offset, loff_t length, if (lcn == RESIDENT_LCN) { if (offset >= clen) { - kfree(res); + __free_page(virt_to_page(res)); if (flags & IOMAP_REPORT) { /* special code for report. */ return -ENOENT; @@ -921,7 +921,7 @@ static int ntfs_iomap_end(struct inode *inode, loff_t pos, loff_t length, out: if (iomap->type == IOMAP_INLINE) { - kfree(iomap->private); + __free_page(virt_to_page(iomap->private)); iomap->private = NULL; } -- 2.53.0