From: Damien Le Moal <dlemoal@kernel.org>
To: Salah Triki <salah.triki@gmail.com>,
cassel@kernel.org, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: Use str_up_down() helper in vt6420_prereset()
Date: Thu, 20 Feb 2025 13:13:31 +0900 [thread overview]
Message-ID: <d20228bb-c1f4-4ebf-9010-e861e0ddceea@kernel.org> (raw)
In-Reply-To: <20250219203554.42727-1-salah.triki@gmail.com>
On 2/20/25 5:35 AM, Salah Triki wrote:
> Remove hard-coded strings by using the str_up_down() helper function.
>
> Signed-off-by: Salah Triki <salah.triki@gmail.com>
This looks OK but the patch title should be:
ata: sata_via: Use str_up_down() helper in vt6420_prereset()
With that fixed,
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2025-02-20 4:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 20:35 [PATCH] ata: Use str_up_down() helper in vt6420_prereset() Salah Triki
2025-02-20 4:13 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d20228bb-c1f4-4ebf-9010-e861e0ddceea@kernel.org \
--to=dlemoal@kernel.org \
--cc=cassel@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=salah.triki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox