From: Jon Hunter <jonathanh@nvidia.com>
To: Greg KH <gregkh@linuxfoundation.org>, Jim Lin <jilin@nvidia.com>
Cc: thierry.reding@gmail.com, linux-tegra@vger.kernel.org,
mathias.nyman@intel.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] xhci: tegra: USB2 pad power controls
Date: Wed, 12 Oct 2022 12:43:16 +0100 [thread overview]
Message-ID: <d219eb55-ebea-091e-d9b0-3881bd4525bf@nvidia.com> (raw)
In-Reply-To: <Y0aikRq2Yi5kYW9j@kroah.com>
On 12/10/2022 12:18, Greg KH wrote:
> On Wed, Oct 12, 2022 at 06:25:11PM +0800, Jim Lin wrote:
>> +static inline struct tegra_xusb *hcd_to_tegra_xusb(struct usb_hcd *hcd)
>> +{
>> + return (struct tegra_xusb *) dev_get_drvdata(hcd->self.controller);
>
> No need for the cast (and if there was, no need for the extra space).
May be best to drop this inline function completely and call
dev_get_drvdata() directly. I only see it used in one place.
Jon
--
nvpublic
next prev parent reply other threads:[~2022-10-12 11:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 10:25 [PATCH v3] xhci: tegra: USB2 pad power controls Jim Lin
2022-10-12 11:18 ` Greg KH
2022-10-12 11:43 ` Jon Hunter [this message]
2022-10-14 9:41 ` Jim Lin
2022-10-12 11:45 ` Jon Hunter
2022-10-17 9:36 ` Jim Lin
2022-10-17 20:17 ` Jon Hunter
2022-10-18 3:20 ` Jim Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d219eb55-ebea-091e-d9b0-3881bd4525bf@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=gregkh@linuxfoundation.org \
--cc=jilin@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox