From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A56C3357A28 for ; Thu, 22 Jan 2026 10:14:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769076848; cv=none; b=KAwT1pazZe3wgiRosn8hl0jLJaj11yJJzQXt6ki/FpOngjStZGTi9m9A8LZk4RDjYRy0LMsn3McYf6PY6yInJ0DwbqEO0vlgbs6E2wv2wnORhsOXhZtuHjAm53J2uPpaUU5xn4wpTGzbKr1Ec491O3MS41A+70Dg68h2PqSi91k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769076848; c=relaxed/simple; bh=not4uNUIV4Fq1tsg7OIn0IGL5/1z7aHYp0CczKY7Ntk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Vpd96e29xed2Y9eL5ViFbbnhG087QrFPcqtjo8KXN8qrgUHkcvundn8+QjnqTRBWCKIz/YUJ0GICpmd/MUb+N4reaHBnCM0Ht46JKSBMA9ody/zCp81IkzoW3aB85W4TMF1tJVppmF7Wev3Ahd9mAOUWZosyFx1TtuopI5cQVmM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EMrLj/ds; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EMrLj/ds" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-4358fb60802so440128f8f.1 for ; Thu, 22 Jan 2026 02:14:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769076845; x=1769681645; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=not4uNUIV4Fq1tsg7OIn0IGL5/1z7aHYp0CczKY7Ntk=; b=EMrLj/dsfMeijJywKVWXMQcbwH15zMf54o5vX4EnBwW8G9DIDUafNztc+oOwciX+4l lgmhsI1rvbgYtrcxUHvpMT1HuCLSGHUjl7XAlfsX6M5FePEoOBuvGoLzTJ2r/znu0XSa ZUkNfkSwcUuNduW/WJIPvwTs0kW8YCikjdsGIe+52q9I+JSvFvxeUXJ2BnXvN6Zc1xAV 3ot+frXuswlzeC/puWNW1Q2+Ww40ZhiHdVUfoLNB/FeO/zQGEDEPAgmVkmvFQj65co4a lgPlyI8CoxnQdQd3FFr8Xi07fM9Io5OCvlFMoyEB8q1G5ebW/ojwEM6nF5XvaQZxJrhP nXGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769076845; x=1769681645; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=not4uNUIV4Fq1tsg7OIn0IGL5/1z7aHYp0CczKY7Ntk=; b=sf3esFUIcPgR9TdRfNvSMhemaBjQn+jOLNhV7CQepo6fngu5TzifNZ+XlxHkjjYJ9b t0DvYjnpgwU6c5MaPPz37CQJlVaGsmoo1Q4Zuv2AT9dkEOqdhfuN68Ajk4zJ0MMDAklU UDHbq2+OmmS/7AiB37J7j8PI6cRaU4++TuGMrGk0lle7O/J7ID2nrPQsA04duZNhlWKp +3h4UZjajLOQOOdn+KhKqR55DHpuyWXr9ThESE0WSDm+ocpNl6WzaBg4G6k1dPaaW2iR F+WKNtQstmDnbSSSM1hAyq5Tjiq47dV+GuilDy7dyZh7S4iBh+oghdKD3KLMNORxxKro sL4g== X-Forwarded-Encrypted: i=1; AJvYcCVLsNhtx1s/gWXUlMy8DhLL2dK4KoxZ5SggoGwwVHniTXVqUMhg9OoWS2QlC/ApgpP+GYvpfJX3NcfHn88=@vger.kernel.org X-Gm-Message-State: AOJu0YyIrvTyVawezLGCC0V/NuhRCD7wa2uDoFjPdgybuEbbUC6neWeq KvHjubj0cqFCbqFczKhXIbhT01Kb5f4M7CAj9IY5C0tMfY88K0Mtcnzu X-Gm-Gg: AZuq6aIGXMS7kq6f11DQz/priwI1NlGG5dGyaTpERPGufC5QARYVDtLBUOJ6hgtD/Xf h5Ht9PhGuO40STMMPM0YbbbuTlegWzT09jdz+/uz9k2LFJ54Wb3ZlyWiZq1gxMgZJ2mkNWevMyM QQ4x3MGqpLOkjIHCyX0zsGMg/4RnD+s1jb6MvSpUpLnaWc+lfOq2F6uxrwVNVpH+6BR1Oh8dzCQ 5h79y3oM7qjHSD6gN7zh5f8Z+byvmeJ0IFfYNtFXahCKDqPvV6aSP+ZwrHUQI8V4lDRX7irK4eu 8JLL3vJLmBrP78PBG8Vx/4OsjXWq+wxnBOO/XBapGrM0gGcgIa6Q2PyxMGU3OFId+DIgt5U5gmi +Ycm3+forLiAWIrUSdT+LWOxXTt8XqMBPeU8c00mv+CzsnFZErn3S/ZArt+G5+1m6LqUjyhOqf7 b5fIzeEY/r/jdT4DXrGLZ7CE39Lmss X-Received: by 2002:a05:6000:420d:b0:425:7e33:b4a9 with SMTP id ffacd0b85a97d-435a5b80722mr5037324f8f.0.1769076844496; Thu, 22 Jan 2026 02:14:04 -0800 (PST) Received: from [10.35.35.136] ([195.37.88.189]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435966322a2sm14652459f8f.38.2026.01.22.02.14.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Jan 2026 02:14:04 -0800 (PST) Message-ID: Date: Thu, 22 Jan 2026 11:14:03 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v5] net: sfp: extend SMBus support Content-Language: en-US To: Andrew Lunn Cc: Maxime Chevallier , Russell King , Heiner Kallweit , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Bj=C3=B8rn_Mork?= References: <20260116113105.244592-1-jelonek.jonas@gmail.com> <6a87648c-a1e8-49a2-a201-91108669ab44@bootlin.com> <6987689b-35ac-4c15-addb-1c8e54144fa7@gmail.com> <5e7c71f6-80dd-408b-a346-888e6febf07a@lunn.ch> <91442f3f-0da9-4c52-89ce-2ca0a3188836@gmail.com> <66e8424c-86c9-4ad7-a3a7-3c277bfa5432@lunn.ch> From: Jonas Jelonek In-Reply-To: <66e8424c-86c9-4ad7-a3a7-3c277bfa5432@lunn.ch> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Andrew, On 18.01.26 16:39, Andrew Lunn wrote: > On Sun, Jan 18, 2026 at 10:43:12AM +0100, Jonas Jelonek wrote: >> Hi, >> >> On 16.01.26 15:25, Andrew Lunn wrote: >>>> But let's first figure-out if word-only smbus are really a thing >>> Some grep foo on /drivers/i2c/busses might answer that. >> Did that and haven't found any driver in mainline which is word-only. >> All drivers with word access capability have byte access too. > So for the moment, maybe add a WARN_ON() for an I2C bus that only > supports word access, and we can deal with it only if we ever get a > report of it firing. Should it just have a WARN_ON and continue (so it may work in some cases) or fail at that point?  Kind regards, Jonas