From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1666C43381 for ; Wed, 20 Feb 2019 15:09:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A34862086D for ; Wed, 20 Feb 2019 15:09:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727146AbfBTPJl (ORCPT ); Wed, 20 Feb 2019 10:09:41 -0500 Received: from mga17.intel.com ([192.55.52.151]:44741 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725842AbfBTPJk (ORCPT ); Wed, 20 Feb 2019 10:09:40 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Feb 2019 07:09:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,391,1544515200"; d="scan'208";a="123897088" Received: from linux.intel.com ([10.54.29.200]) by fmsmga007.fm.intel.com with ESMTP; 20 Feb 2019 07:09:40 -0800 Received: from [10.125.252.177] (abudanko-mobl.ccr.corp.intel.com [10.125.252.177]) by linux.intel.com (Postfix) with ESMTP id D552758028E; Wed, 20 Feb 2019 07:09:37 -0800 (PST) Subject: Re: [PATCH v2 3/4] perf record: enable runtime trace compression To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Namhyung Kim , Alexander Shishkin , Andi Kleen , linux-kernel References: <044ee2be-2e1d-e90f-7317-40083b5e716c@linux.intel.com> <5bc6958d-f4bc-d4ea-e5d0-16c5e7b73911@linux.intel.com> <20190212130902.GI775@krava> From: Alexey Budankov Organization: Intel Corp. Message-ID: Date: Wed, 20 Feb 2019 18:09:36 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20190212130902.GI775@krava> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12.02.2019 16:09, Jiri Olsa wrote: > On Mon, Feb 11, 2019 at 11:23:40PM +0300, Alexey Budankov wrote: > > SNIP > >> + compress_fn = (record__comp_enabled(rec) ? >> + perf_session__zstd_compress : perf_session__zstd_copy); >> + >> if (record__aio_enabled(rec)) >> off = record__aio_get_pos(trace_fd); >> >> @@ -799,11 +805,21 @@ static int record__mmap_read_evlist(struct record *rec, struct perf_evlist *evli >> map->flush = MMAP_FLUSH_DEFAULT; >> } >> if (!record__aio_enabled(rec)) { >> - if (perf_mmap__push(map, rec, record__pushfn) != 0) { >> - if (sync) >> - map->flush = flush; >> - rc = -1; >> - goto out; >> + if (!record__comp_enabled(rec)) { >> + if (perf_mmap__push(map, rec, record__pushfn) != 0) { >> + if (sync) >> + map->flush = flush; >> + rc = -1; >> + goto out; >> + } >> + } else { >> + if (perf_mmap__pack(map, rec, record__pushfn, >> + compress_fn, session) != 0) { >> + if (sync) >> + map->flush = flush; >> + rc = -1; >> + goto out; >> + } > > I really dont like this.. the non-compression flow needs to stay untouched > > why don't you overload the record__pushfn function for compression > processing and stash the data in there? Yes, this becomes complicated and overloading could be an option to simplify it. Thanks, Alexey > > thanks, > jirka >