From: Zijun Hu <zijuhu@codeaurora.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-bluetooth@vger.kernel.org, linux-arm-msm@vger.kernel.org,
bgodavar@codeaurora.org, c-hbandi@codeaurora.org,
hemantg@codeaurora.org, mka@chromium.org, rjliao@codeaurora.org
Subject: Re: [PATCH v2] Bluetooth: hci_qca: Improve controller ID info log level
Date: Thu, 28 May 2020 17:31:12 +0800 [thread overview]
Message-ID: <d238c1ac-bcce-28f5-4d74-66e0bc4189c4@codeaurora.org> (raw)
In-Reply-To: <A9C9A8F9-01AA-40D9-A0CA-25BA18B74BDA@holtmann.org>
On 5/28/2020 4:16 PM, Marcel Holtmann wrote:
> Hi Zijun,
>
>> Controller ID info got by VSC EDL_PATCH_GETVER is very
>> important, so improve its log level from DEBUG to INFO.
>>
>> Signed-off-by: Zijun Hu <zijuhu@codeaurora.org>
>> ---
>> drivers/bluetooth/btqca.c | 12 ++++++++----
>> 1 file changed, 8 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
>> index 3ea866d..94d8e15 100644
>> --- a/drivers/bluetooth/btqca.c
>> +++ b/drivers/bluetooth/btqca.c
>> @@ -74,10 +74,14 @@ int qca_read_soc_version(struct hci_dev *hdev, u32 *soc_version,
>>
>> ver = (struct qca_btsoc_version *)(edl->data);
>>
>> - BT_DBG("%s: Product:0x%08x", hdev->name, le32_to_cpu(ver->product_id));
>> - BT_DBG("%s: Patch :0x%08x", hdev->name, le16_to_cpu(ver->patch_ver));
>> - BT_DBG("%s: ROM :0x%08x", hdev->name, le16_to_cpu(ver->rom_ver));
>> - BT_DBG("%s: SOC :0x%08x", hdev->name, le32_to_cpu(ver->soc_id));
>> + bt_dev_info(hdev, "QCA Product ID :0x%08x",
>> + le32_to_cpu(ver->product_id));
>> + bt_dev_info(hdev, "QCA SOC Version :0x%08x",
>> + le32_to_cpu(ver->soc_id));
>> + bt_dev_info(hdev, "QCA ROM Version :0x%08x",
>> + le16_to_cpu(ver->rom_ver));
>> + bt_dev_info(hdev, "QCA Patch Version:0x%08x",
>> + le16_to_cpu(ver->patch_ver));
>
> please align correctly according to the coding style.
>
if bt_dev_info() is wrote at one line, it will exceed 80 characters
so i split it at two line and aligned via vim.
> Regards
>
> Marcel
>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
prev parent reply other threads:[~2020-05-28 9:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 2:57 [PATCH v2] Bluetooth: hci_qca: Improve controller ID info log level Zijun Hu
2020-05-27 16:23 ` Matthias Kaehlcke
2020-05-28 8:16 ` Marcel Holtmann
2020-05-28 9:31 ` Zijun Hu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d238c1ac-bcce-28f5-4d74-66e0bc4189c4@codeaurora.org \
--to=zijuhu@codeaurora.org \
--cc=bgodavar@codeaurora.org \
--cc=c-hbandi@codeaurora.org \
--cc=hemantg@codeaurora.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mka@chromium.org \
--cc=rjliao@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox