From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 418DEC7EE2A for ; Mon, 22 May 2023 22:23:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234654AbjEVWXE (ORCPT ); Mon, 22 May 2023 18:23:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232351AbjEVWXB (ORCPT ); Mon, 22 May 2023 18:23:01 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAE4DAF for ; Mon, 22 May 2023 15:22:59 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2af29e51722so41282991fa.1 for ; Mon, 22 May 2023 15:22:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684794178; x=1687386178; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qJSRzVQri63512zNj0i13qdp4vOsM52UNAxzsHm7fSM=; b=dV1cA/FSpBZMzQbz3HzmD1WbNWtkWKi9IaHOyNK7w2lqr8Z+vqGJtb6F4R4R36Qt8p 3EZQDQjZGtyv/2Y+rHauGI3mjBZsRlbdrShLBfmmDyKli4KJT2t2wwCqN0GpBLKDOFiZ ZvTzDCNnIPrcWBGAoOAMee6Wn+b4xjiNd+s02RKA0Iz6lksrhbiDNP76IalSB6NZojYe l/+gSA+IBogxGoVHTiUt8WDldZ/HQ2xEsx99f1mfmOrxBKtosE52AIOXepZxHaPgnmmP JlIvSvBtAJX5TNu69dDGogTOWX0hhpD690GoILH+zolC1ieHaTMjE7eycZN+yBVe9eRU YnOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684794178; x=1687386178; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qJSRzVQri63512zNj0i13qdp4vOsM52UNAxzsHm7fSM=; b=O7440LwwvAwswbA/C/NzlrESX9Pm3dJbyzEujcVUl/gHhYI5pxFyiY+i9LueR6zEU1 aU7WauX9yII6/Q3e2ChO8OqQm+Hc/uC1Tf3NFfq8SBX+2NUKCiPAyKwRPNRXonhNhWd6 B4x9U7BKh0grh3Q+fDYYQJ0e424E1t6d8rywnYAyiBHGCyYWsBEfdnnxg7iu0/o4kNo6 SCvNzlUS185JVZ+NB/HUfpg+IjfjAzYXjvZdFWQ6Y7xFL9JuYDF/4zLelZJeOGL+uO46 ALGTN8d9oUUsQbo1AQUTBzqZLqIx+kw8+NOHOPfsitbPP1SwFVEmn+We19gfvitcg1rQ QmpA== X-Gm-Message-State: AC+VfDy4gOZ6DB33qWsjCddzYTUNdRpblGXSUAmyIxEf6NvWOKX/89RY v3nvzhu79F/bPHo5B0BnpQb02g== X-Google-Smtp-Source: ACHHUZ7A0qFcQpm73ab9A5tSwcE+/ROdROgeCckH/XTp/VBb7N196FM9OXNv84bY1bb3cPOx0n6S9g== X-Received: by 2002:a2e:7a10:0:b0:2af:21d3:a4ca with SMTP id v16-20020a2e7a10000000b002af21d3a4camr4029540ljc.47.1684794178146; Mon, 22 May 2023 15:22:58 -0700 (PDT) Received: from ?IPV6:2001:14ba:a0db:1f00::8a5? (dzdqv0yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0db:1f00::8a5]) by smtp.gmail.com with ESMTPSA id d18-20020a2e3612000000b002a8c32fd2f3sm1325856lja.89.2023.05.22.15.22.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 May 2023 15:22:57 -0700 (PDT) Message-ID: Date: Tue, 23 May 2023 01:22:57 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 1/5] msm/drm/dsi: Round up DSC hdisplay calculation Content-Language: en-GB To: Marijn Suijten Cc: Jessica Zhang , Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , Konrad Dybcio , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20230405-add-dsc-support-v4-0-15daf84f8dcb@quicinc.com> <20230405-add-dsc-support-v4-1-15daf84f8dcb@quicinc.com> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/05/2023 01:18, Marijn Suijten wrote: > On 2023-05-23 01:14:40, Dmitry Baryshkov wrote: >> On Tue, 23 May 2023 at 00:45, Jessica Zhang wrote: >>> >>> >>> >>> On 5/22/2023 1:44 PM, Marijn Suijten wrote: >>>> On 2023-05-22 13:30:20, Jessica Zhang wrote: >>>>> Currently, when compression is enabled, hdisplay is reduced via integer >>>>> division. This causes issues for modes where the original hdisplay is >>>>> not a multiple of 3. >>>>> >>>>> To fix this, use DIV_ROUND_UP to divide hdisplay. >>>>> >>>>> Reviewed-by: Marijn Suijten >>>>> Suggested-by: Marijn Suijten >>>> >>>> Nit: probably these should go in the opposite order. And if they're >>>> all supposed to be chronological, I think it is: >>>> >>>> Suggested-by: >>>> Fixes: >>>> Signed-off-by: >>>> Reviewed-by: >>>> >>>> But unsure if that's a hard requirement, or even correct at all. >>> >>> Hi Marijn, >>> >>> I don't see any explicit documentation on the order of R-b tags. FWIW, I >>> see in the git log that S-o-b always goes at the bottom of the commit >>> message. >>> >>> I would prefer the S-o-b to always be at the bottom (as it helps me >>> avoid duplicate S-o-b's when doing `git commit -s`), though I can flip >>> the order of the R-b and suggested-by tags. >> >> I'd second Jessica here. Consider these tags as a history or a transcript: >> >> I would not vote on the particular order of the Suggested-by/Fixes >> tags, I don't think that is important. These come first. Then the >> patch goes through different cycles. of reviews, which gain >> Reviewed-by tags. >> >> In the same way Link/Patchwork/whatever other tags are added in the >> historical order. >> >> By having the submitter's S-o-b at the bottom, the submitter adds the >> final signature under everything else being stated/recorded. > > Correct, so the s-o-b can always be kept / moved back to the bottom on a > resend, stating that they sign off on "all that was written previously" > including picking up reviews. > > However, for the rest of your reply about "history / transcript", you > seem to agree exactly with my point of keeping (or rather, simply > appending) these in chronological order? Yes. > > - Marijn > >> >> Of course, in a more complicated story, there might be other >> developers taking part (Co-Developed-By + Signed-off-by), etc. >> >> Note: all described is just my perception and might differ from the >> BCP regarding the tags. > > -- With best wishes Dmitry