public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "James Tai [戴志峰]" <james.tai@realtek.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-realtek-soc@lists.infradead.org" 
	<linux-realtek-soc@lists.infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Marc Zyngier <maz@kernel.org>
Subject: RE: [PATCH 1/6] dt-bindings: interrupt-controller: Add support for Realtek DHC SoCs
Date: Thu, 16 Nov 2023 14:37:30 +0000	[thread overview]
Message-ID: <d276118d69f648c8b236d5681ecb4bc1@realtek.com> (raw)
In-Reply-To: <72024444-da43-47e3-a76f-4107bda8e402@kernel.org>

Hi Krzysztof,

>
>Please run scripts/checkpatch.pl and fix reported warnings. Some warnings can
>be ignored, but the code here looks like it needs a fix.
>Feel free to get in touch if the warning is not clear.
>

I will run checkpatch.pl to address and fix the reported warnings.

>Please use scripts/get_maintainers.pl to get a list of necessary people and lists
>to CC. It might happen, that command when run on an older kernel, gives you
>outdated entries. Therefore please be sure you base your patches on recent
>Linux kernel.
>
>You missed at least devicetree list (maybe more), so this won't be tested by
>automated tooling. Performing review on untested code might be a waste of
>time, thus I will skip this patch entirely till you follow the process allowing the
>patch to be tested.
>
>Please kindly resend and include all necessary To/Cc entries.

I will fix it in the next patches.

>
>It does not look like you tested the bindings, at least after quick look. Please run
>`make dt_binding_check` (see
>Documentation/devicetree/bindings/writing-schema.rst for instructions).
>Maybe you need to update your dtschema and yamllint.
>
I will test the bindings using 'make dt_binding_check'.

Thank you for your feedback.

Regards,
James


  reply	other threads:[~2023-11-16 14:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-02 14:27 [PATCH 0/6] Initial support for the Realtek interrupt controller James Tai
2023-11-02 14:27 ` [PATCH 1/6] dt-bindings: interrupt-controller: Add support for Realtek DHC SoCs James Tai
2023-11-03  6:49   ` Krzysztof Kozlowski
2023-11-16 14:37     ` James Tai [戴志峰] [this message]
2023-11-16 14:46       ` Krzysztof Kozlowski
2023-11-02 14:27 ` [PATCH 2/6] irqchip: Add interrupt controller " James Tai
2023-11-06 11:30   ` Thomas Gleixner
2023-11-16 15:25     ` James Tai [戴志峰]
2023-11-17  9:44       ` James Tai [戴志峰]
2023-11-02 14:27 ` [PATCH 3/6] irqchip: Introduce RTD1319 support using the Realtek Common Interrupt Controller Driver James Tai
2023-11-06  4:26   ` kernel test robot
2023-11-06 17:06   ` Thomas Gleixner
2023-11-16 15:29     ` James Tai [戴志峰]
2023-11-02 14:27 ` [PATCH 4/6] irqchip: Introduce RTD1319D " James Tai
2023-11-06  4:03   ` kernel test robot
2023-11-02 14:27 ` [PATCH 5/6] irqchip: Introduce RTD1325 " James Tai
2023-11-06  7:00   ` kernel test robot
2023-11-02 14:27 ` [PATCH 6/6] irqchip: Introduce RTD1619B " James Tai
2023-11-06 10:26   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d276118d69f648c8b236d5681ecb4bc1@realtek.com \
    --to=james.tai@realtek.com \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-realtek-soc@lists.infradead.org \
    --cc=maz@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox