From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44EAE322B88 for ; Fri, 17 Apr 2026 07:22:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776410579; cv=none; b=rtvnd3MsrpWbKN7oyM75LWp0GS32BdLporZ6tyjuOh3wv1m8O+LFEtx/I4J3O9NHgLq2ZfrPy4akrJnNv+vMkNJMElzUEcW1R/hFPNgJkjl9Ak/y34mgBQyb6vRrlgqAZrfa1SDIp6ECYauMPVWKXU8ESV3wknqvCcyaRz8amXw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776410579; c=relaxed/simple; bh=UJgzyvp8IsFYlpKz06IFX+wXpWmB7rGHydrnTHw/5Qc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=A38sraHJA1C6PJzd7nRitVSCGzHqwA+J1VHGDcbuJKBnwrB5R9DtEVSSqiXuNrnxet+l4YgNODnExYIa34JcOkGLpSVSB7/OvoxEtK7geeMVM+JNKL8MXCuz/FbnCBnM1qUSktvG4DYRDubZwalA5SAg0mao/rh5rbJaRq63naI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=K5+al1qC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=f2+Ym+Bq; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="K5+al1qC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="f2+Ym+Bq" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63H18JuD667843 for ; Fri, 17 Apr 2026 07:22:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wlzWYEhWl+ZJwHWIE9kkJeytw0Lnh1NUX+uLXgzgrds=; b=K5+al1qClvJTL8dT NiLyLOD1AdLebM+Acm/RJmPQ7T45RAbHlpAh/9zPdQYWviBeK3rBSnR3JnE2CcKg F9T0V8yqEW92Eq+S89nGpzqtJOKB43the83n1xZn13xASWs8Asj0EopqWBrh3GZO i9wbWgnxunUU+Naxs378my4TQbiHYI/0D+jwxlY2SW8c/mAClI4naZc3/Z8ba244 nLOnvGgSkmCew/wpmgeVfmPIuf+ufk0iKSMgj3AC4ce6AZmN1lnqb90PNvGQyvgG Tssl8rl84aIGAW+8WjDtkrmhlT+wGo3eoiBeKDPkRJSTUhcU+4Sqsr4Hv214Htad H6Pgnw== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dkaxcs088-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Apr 2026 07:22:57 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-35d99c2908cso523983a91.0 for ; Fri, 17 Apr 2026 00:22:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776410576; x=1777015376; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wlzWYEhWl+ZJwHWIE9kkJeytw0Lnh1NUX+uLXgzgrds=; b=f2+Ym+BqQjEGEGu0glkV0fWK0tDDr54UQb8aFbpNZjlDdc4aiTg+DBfPHR5122x97S HT/PwHisW7KXJoNFSoOxPR9nvgSy4Jy2WSHJzUJAlMLhqB864dlL4/ngYZ3F7o2jIxSV icubXsBQSsmYUiVzZiOnUkEJR4KlQC3tdDqXA7hMsic62UvK/7oTA/+k+oUZO62nUlnA o1Ocq8Y4FSG79StRqqvNEseQCOUj6DTKMwjmB1sPIAKfOaj0pX6lPNmZGVx+CoSB/MMj m7H7SRxwzt5enY83o5e+AV3nDTWTImlLGRbXW21HNLd7AGnXgxQKwZJv+jscaAx9Ze8n mx2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776410576; x=1777015376; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wlzWYEhWl+ZJwHWIE9kkJeytw0Lnh1NUX+uLXgzgrds=; b=qT0TP1qW1Z+3jWgJKS0cOt/rNN+jMQanqgSE84Sp30BlHs5FbW4Fsd1ZaNy6unrbb1 OFsItLLVoLDjC8DAeydyFSNnz+/xXkyt/YiuDEAaliTWSKX4BmnjoKUzsjQ9AAW7I53g UkZM73SAWVS4wndfNPK28kfXDEnvWnNred5JE+R9q8rq3vB2bKdyTDtGiX1rfosXf+wF 4QedcWv8dZVjE/dAY3J+Nbn9LaSfAblhlOPXBduqfwMP0xufP9cjwp14NRhG1fatkiAh IcNmtMvUhZ7kTIjvIjSqGq6s3BJLx1ngTa78Vp3y+jjubE/F4WX6k+rWx1oX3EuLdmA+ K/qg== X-Forwarded-Encrypted: i=1; AFNElJ86kCsY1RakrneI35grvI8vT8zOV0gJ9S+djPXJy2DAgdSQyepooM2g/q6fz7RY2Il4oN3Cbdp34xP2eR4=@vger.kernel.org X-Gm-Message-State: AOJu0Ywlg//v76Dfh2YThRpKGldGy85aSq+Iefh1GTiN0OqpfuG/VGeT cIhRthFK/rMhj3IhEqTHZ4Dkm1uZAjBIrbwJX1S8+lNVep5KawMdKLqC32zZbq7gK09OgvGQOFN nsxIw6E8vhorHF45MsDZa6cuNhjlpYpsBeTQtdVAmZxz/SsJdqwkkYAbQF75+n3SUS5A= X-Gm-Gg: AeBDietJV0UKK/OsJb67MY+IxNhvfcSlCylV2DaZvwYxUvU2rxlDV5dFv4jdDNC+y7H NTyyuHCcRr4uGpyxphZskh0m6JoCYg0afYAjZVEihITApVpEQE3NDvHElFDwHY0mCYR5y6yT6+n NyQ5RFXP4gM7ephq/394Xj0cnWg2DQwXOdIdux6l++P/TnreCNU9V2r99HN8RpFs/qafiw0Vrix ycBG7VqjkdwefP7eWtN+50p2iFRNZki+f4sta8g2dHIwwlh9NQMUkDi6E44Jlbh/c5N46sTWTdo Q3/zntUGap3mUYnMyXp1hrAePVEUljOHeN/+TMoFIF9+DHvH3QffRIHtXgRwCjU0PImrpTlWj4h OeUWiCepj6gA+YCwmPm2XZ4uzUUycCwMDVvVFV+ud/5JAZiQ+tUjsBwelrV2nNXpd X-Received: by 2002:a17:90b:164a:b0:35f:b572:ece3 with SMTP id 98e67ed59e1d1-361403bd001mr1808884a91.6.1776410575882; Fri, 17 Apr 2026 00:22:55 -0700 (PDT) X-Received: by 2002:a17:90b:164a:b0:35f:b572:ece3 with SMTP id 98e67ed59e1d1-361403bd001mr1808850a91.6.1776410575311; Fri, 17 Apr 2026 00:22:55 -0700 (PDT) Received: from [10.0.0.3] ([106.222.231.221]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3613f5766c4sm622269a91.0.2026.04.17.00.22.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Apr 2026 00:22:54 -0700 (PDT) Message-ID: Date: Fri, 17 Apr 2026 12:52:50 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH RFC 2/7] media: qcom: iris: gen2: add support for 10bit decoding Content-Language: en-US To: Neil Armstrong , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260408-topic-sm8x50-iris-10bit-decoding-v1-0-428c1ec2e3f3@linaro.org> <20260408-topic-sm8x50-iris-10bit-decoding-v1-2-428c1ec2e3f3@linaro.org> From: Dikshita Agarwal In-Reply-To: <20260408-topic-sm8x50-iris-10bit-decoding-v1-2-428c1ec2e3f3@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=JcqMa0KV c=1 sm=1 tr=0 ts=69e1dfd1 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=llJV7PLoYzplBNayqe3woA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=KKAkSRfTAAAA:8 a=VRqzhRILX_6Jt83UIxkA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE3MDA3MiBTYWx0ZWRfX1cEhW/ZJb5Ue DSqjcl5p8JxPBlP+Uotx+K9RGiSEaAgV6v2Wh+1rO8Cc2A89AL+mzwLi1g4llFmX1yUGdFDPe0U JI0NzWXdnVX3J7wDrBD7Ub2r/EVkxZLxLUw5uK+YXyTYNFjxDJyEQIEl209499mGvDTtlrBesFH aNk9ZEA5dMTsFJ6U9yv65212hPuDynM0o12EtX5+lV4XVBn8CGogJfEjbJbQQ0Bb5pq6CfcFDig gSQbeTpJdTKTwM5HvQZj0zdrxz9KoI6ie5XFY9AvAcr7GbqSp3omaSeYZwLHjRKIAx8nrBSxND7 12DACnpMFmuFIIF2g9PeHVkknqgm8gNQp5CDQ1ABxHVPjfbfVpP/iU0JDDJ2HLTT1CPrt4Dki+2 Yy2KzLUjjwwWYC5KLjbLCL+SiLGy0/mBOwSU+HbHxDXhXSyAcCQyJ6gfKw23oOGORuZ+HuiNIAA snKYIvoF01vQTkYKeZQ== X-Proofpoint-GUID: 6jrHEplUgxcFX2cIiPiTNIkyEutq5Jvz X-Proofpoint-ORIG-GUID: 6jrHEplUgxcFX2cIiPiTNIkyEutq5Jvz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-16_04,2026-04-16_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 clxscore=1015 malwarescore=0 phishscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604170072 On 4/8/2026 10:13 PM, Neil Armstrong wrote: > Add the necessary plumbing into the HFi Gen2 to signal the decoder > the right 10bit pixel format and stride when in compressed mode. > > Signed-off-by: Neil Armstrong > --- > .../platform/qcom/iris/iris_hfi_gen2_command.c | 71 +++++++++++++++++++++- > .../platform/qcom/iris/iris_hfi_gen2_defines.h | 1 + > drivers/media/platform/qcom/iris/iris_utils.c | 4 +- > 3 files changed, 72 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c > index 30bfd90d423b..8e547e390fa3 100644 > --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c > +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c > @@ -481,8 +481,20 @@ static int iris_hfi_gen2_set_colorformat(struct iris_inst *inst, u32 plane) > > if (inst->domain == DECODER) { > pixelformat = inst->fmt_dst->fmt.pix_mp.pixelformat; > - hfi_colorformat = pixelformat == V4L2_PIX_FMT_NV12 ? > - HFI_COLOR_FMT_NV12 : HFI_COLOR_FMT_NV12_UBWC; > + switch (pixelformat) { > + case V4L2_PIX_FMT_NV12: > + hfi_colorformat = HFI_COLOR_FMT_NV12; > + break; > + case V4L2_PIX_FMT_QC08C: > + hfi_colorformat = HFI_COLOR_FMT_NV12_UBWC; > + break; > + case V4L2_PIX_FMT_P010: > + hfi_colorformat = HFI_COLOR_FMT_P010; > + break; > + case V4L2_PIX_FMT_QC10C: > + hfi_colorformat = HFI_COLOR_FMT_TP10_UBWC; > + break; > + }; > } else { > pixelformat = inst->fmt_src->fmt.pix_mp.pixelformat; > hfi_colorformat = pixelformat == V4L2_PIX_FMT_NV12 ? > @@ -517,7 +529,8 @@ static int iris_hfi_gen2_set_linear_stride_scanline(struct iris_inst *inst, u32 > stride_uv = stride_y; > scanline_uv = scanline_y / 2; > > - if (pixelformat != V4L2_PIX_FMT_NV12) > + if (pixelformat != V4L2_PIX_FMT_NV12 && > + pixelformat != V4L2_PIX_FMT_P010) > return 0; > > payload[0] = stride_y << 16 | scanline_y; > @@ -532,6 +545,57 @@ static int iris_hfi_gen2_set_linear_stride_scanline(struct iris_inst *inst, u32 > sizeof(u64)); > } > > +static int iris_hfi_gen2_set_ubwc_stride_scanline(struct iris_inst *inst, u32 plane) > +{ > + u32 meta_stride_y, meta_scanline_y, meta_stride_uv, meta_scanline_uv; > + u32 stride_y, scanline_y, stride_uv, scanline_uv; > + u32 port = iris_hfi_gen2_get_port(inst, plane); > + u32 pixelformat, width, height; > + u32 payload[4]; > + > + pixelformat = inst->fmt_dst->fmt.pix_mp.pixelformat; > + width = inst->fmt_dst->fmt.pix_mp.width; > + height = inst->fmt_dst->fmt.pix_mp.height; This HFI is only applicable to AV1, you might see some corruption due to this. Please check. Thanks, Dikshita