From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9393721D596; Tue, 16 Jun 2026 23:55:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781654132; cv=none; b=tkCnqxeERatMrmUO101zeH0VkRJERUMV9+KI4IyNDzug54zJ/jp+wQKHrWJrVKmkry0AjGvTt39Uj3s22am1lFDeRhkMYGKmG2G+jFK184TkTT1Ou25hCXQh43gG4YqCWUFHfPZIenB9KsdKArNUqeSgwAQlefO49oW8953CsP0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781654132; c=relaxed/simple; bh=SDmIBId0ITXPr94PESh2YNLWgSq9W6bRB7Yfjw907W8=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=gMwS8ZzSrVB5VXA/k8YK8vmQVyit4FrYiy6/EVzvntdA1ZBCqBwloTbaD/gT7qmOCp9Dp+pzQxTGwuGzTTzitpY9s8T+93P+VWtA6aKZP6a5xf/xVBtoEZolIjSLhV4oeCEWRZwG/A6SSzbXIkN/fLKzkxNJdlWMI3lYa7S9OLY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NzMoLksD; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NzMoLksD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 829AF1F00A3D; Tue, 16 Jun 2026 23:55:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781654131; bh=zLdTwqbeehqCKRrfdVRiWtHbT6AUgFS6H0xX4wk3A/s=; h=Date:From:To:Cc:In-Reply-To:References:Subject; b=NzMoLksDjPU/zEUY0Zn/wo9MAcUsn3b9WTU/Cboa6COYZCkc41QFHCs5AAuE6oZCB l1VVSO8LjKEz672Y15JIiT+fyGvdKCBTmzNkCsSmq71mwwWGcilUVZNlMP/5CT3qiR 9UsKFOha1BEvWTd/0iHsrMWSLrtV65b5YUo9NdCUhnXGCWMPc3XbMcVHbqAPbk4Eo+ LRD46vfz0LoqQYTe4ofOcMiyrPMEmm6+Qmv8jcOrMB6VzVXCt2ZF7SjrXSuUQNpKZ3 +DKBAk+rDlCR/maj68rA3DgRh2WxUvh763FGlK+e93NLsqlpB/FoutQT7btKiv4RHn Me/V+dk0gYRtg== Received: from phl-compute-10.internal (phl-compute-10.internal [10.202.2.50]) by mailfauth.phl.internal (Postfix) with ESMTP id AA092F40082; Tue, 16 Jun 2026 19:55:29 -0400 (EDT) Received: from phl-imap-15 ([10.202.2.104]) by phl-compute-10.internal (MEProxy); Tue, 16 Jun 2026 19:55:29 -0400 X-ME-Sender: X-ME-Proxy-Cause: dmFkZTGKv/73K9Q/iMN9KBKYeOGfzfcyLZdCGUapQlr+Y5h7YvHT0jFxaXZed4fWbzf1N0 zCPy49rpMyyycy/kF6HkmuKbN3eVydqcEO5uXv+ISGsBkFQhlGANbHdrtXF+19wIxCJh87 ZLQ6tirMyJgHXFAkO/SdZt2njPyPEReNhTPtZ0qUGsKuVUgBBh5dryY/8gtycof1YrddSD 8Ltc59R1mvifod6oPfNE4pJz7wwSOoC6cT8+Z02hTyfdfR44Sl6VB7l7D0d3VLlDywv+DC 57hEiRYB0w9/MA/f1txn1QrHcNdMGchuaovR1j4Epm7pKO9dLeyNnUMCdrDOUyHk4ydoME uxb6LxIFO3Ix4HGiyDUSVo3gUz/RReJePNIayhzCzfW4u5rQYCbgAi8/SaDjc7L/HlAENt YOW/KDkj0XB15sSS9EK8szczYt1hdjLo89BjDFUv+NSeYypcNF7KZJxFM9rU3w67I+vHNR /QKmJO2bDqiHEF9ZyEcE3ddHJ4sNd8KxpqgONUzkc5i75O/7Q5CmLA1u0DTC+gV9m9Xol0 yjgKDkrrIak3albCJPjihUt3PqnhJ1C+fVEyoGLL6QH+TA03Q4ezCAOHKxLQ4a8xVWcBWW JOPDL6gHfNcxADCbEVMfSzh+QUnI4HrBJbk8ljZiN/wD5nsWr9Y48CHBAxbQ X-ME-Proxy: Feedback-ID: ifa6e4810:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 87A4E780070; Tue, 16 Jun 2026 19:55:29 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Tue, 16 Jun 2026 19:55:08 -0400 From: "Chuck Lever" To: "Jeff Layton" , NeilBrown , "Olga Kornievskaia" , "Dai Ngo" , "Tom Talpey" Cc: "Trond Myklebust" , "Anna Schumaker" , "Steve Dickson" , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: In-Reply-To: <20260616-exportd-netlink-v4-1-03505aee3883@kernel.org> References: <20260616-exportd-netlink-v4-0-03505aee3883@kernel.org> <20260616-exportd-netlink-v4-1-03505aee3883@kernel.org> Subject: Re: [PATCH v4 1/4] sunrpc: add per-netns per-procedure call counts to svc_stat Content-Type: text/plain Content-Transfer-Encoding: 7bit Hey Jeff - On Tue, Jun 16, 2026, at 8:45 AM, Jeff Layton wrote: > The existing per-procedure call counts live in global > svc_version->vs_count[] arrays which are not network-namespace-aware. > Add per-netns equivalents in struct svc_stat so the upcoming netlink > stats interface can return namespace-scoped statistics. > > Add a vs_count pointer array to struct svc_stat, along with > svc_stat_alloc_counts() and svc_stat_free_counts() helpers to manage > per-version percpu call count arrays. This patch appears to break the build for an NFSv3-only server configured with CONFIG_PROC_FS=n. svc_stat_alloc_counts() and svc_stat_free_counts() are defined in net/sunrpc/stats.c, which the Makefile builds only under PROC_FS: sunrpc-$(CONFIG_PROC_FS) += stats.o nfsd_net_init()/nfsd_net_exit() call both helpers unconditionally, and the declarations in sit outside the #ifdef CONFIG_PROC_FS block with no !PROC_FS stubs. CONFIG_NFSD does not depend on PROC_FS -- only NFSD_V4 does -- so NFSD=y with NFSD_V2/V3 and PROC_FS=n is a valid Kconfig combination. The result is an undefined reference to svc_stat_alloc_counts at vmlinux link (NFSD=y), or a modpost failure for NFSD=m since both symbols are EXPORT_SYMBOL_GPL. net/sunrpc/svc.c is always built, and might be a more natural home for the new functions. -- Chuck Lever