From: Waiman Long <llong@redhat.com>
To: "Michal Koutný" <mkoutny@suse.com>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Tejun Heo <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH v2 02/11] cgroup/cpuset-v1: Add deprecation messages to memory_spread_page and memory_spread_slab
Date: Tue, 11 Mar 2025 11:07:03 -0400 [thread overview]
Message-ID: <d2a3328e-c8b1-4697-9a97-c198fe672f40@redhat.com> (raw)
In-Reply-To: <20250311123640.530377-3-mkoutny@suse.com>
On 3/11/25 8:36 AM, Michal Koutný wrote:
> There is MPOL_INTERLEAVE for user explicit allocations.
> Deprecate spreading of allocations that users carry out unwittingly.
> Use straight warning level for slab spreading since such a knob is
> unnecessarily intertwined with slab allocator.
>
> Signed-off-by: Michal Koutný <mkoutny@suse.com>
> ---
> kernel/cgroup/cpuset-v1.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kernel/cgroup/cpuset-v1.c b/kernel/cgroup/cpuset-v1.c
> index 9d47b20c03c4b..fea8a0cb7ae1d 100644
> --- a/kernel/cgroup/cpuset-v1.c
> +++ b/kernel/cgroup/cpuset-v1.c
> @@ -441,9 +441,11 @@ static int cpuset_write_u64(struct cgroup_subsys_state *css, struct cftype *cft,
> cpuset_memory_pressure_enabled = !!val;
> break;
> case FILE_SPREAD_PAGE:
> + pr_info_once("cpuset.%s is deprecated\n", cft->name);
> retval = cpuset_update_flag(CS_SPREAD_PAGE, cs, val);
> break;
> case FILE_SPREAD_SLAB:
> + pr_warn_once("cpuset.%s is deprecated\n", cft->name);
> retval = cpuset_update_flag(CS_SPREAD_SLAB, cs, val);
> break;
> default:
Acked-by: Waiman Long <longman@redhat.com>
next prev parent reply other threads:[~2025-03-11 15:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 12:36 [PATCH v2 00/11] cgroup v1 deprecation messages Michal Koutný
2025-03-11 12:36 ` [PATCH v2 01/11] cgroup/cpuset-v1: Add deprecation messages to sched_load_balance and memory_pressure_enabled Michal Koutný
2025-03-11 14:02 ` Waiman Long
2025-03-11 12:36 ` [PATCH v2 02/11] cgroup/cpuset-v1: Add deprecation messages to memory_spread_page and memory_spread_slab Michal Koutný
2025-03-11 15:07 ` Waiman Long [this message]
2025-03-11 12:36 ` [PATCH v2 03/11] cgroup/blkio: Add deprecation messages to reset_stats Michal Koutný
2025-03-11 12:36 ` [PATCH v2 04/11] cgroup: Print message when /proc/cgroups is read on v2-only system Michal Koutný
2025-03-11 12:36 ` [PATCH v2 05/11] cgroup/cpuset-v1: Add deprecation messages to mem_exclusive and mem_hardwall Michal Koutný
2025-03-11 15:08 ` Waiman Long
2025-03-11 12:36 ` [PATCH v2 06/11] cgroup/cpuset-v1: Add deprecation messages to memory_migrate Michal Koutný
2025-03-11 15:09 ` Waiman Long
2025-03-11 12:36 ` [PATCH v2 07/11] RFC cgroup/cpuset-v1: Add deprecation messages to sched_relax_domain_level Michal Koutný
2025-03-11 15:10 ` Waiman Long
2025-03-11 15:10 ` Waiman Long
2025-03-11 12:36 ` [PATCH v2 08/11] mm: Add transformation message for per-memcg swappiness Michal Koutný
2025-03-11 12:36 ` [PATCH v2 09/11] cgroup: Add deprecation message to legacy freezer controller Michal Koutný
2025-03-11 12:36 ` [PATCH v2 10/11] cgroup: Update file naming comment Michal Koutný
2025-03-11 12:36 ` [PATCH v2 11/11] blk-cgroup: Simplify policy files registration Michal Koutný
2025-03-11 18:56 ` [PATCH v2 00/11] cgroup v1 deprecation messages Jens Axboe
2025-03-11 19:23 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2a3328e-c8b1-4697-9a97-c198fe672f40@redhat.com \
--to=llong@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkoutny@suse.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox