From: Lars Melin <larsm17@gmail.com>
To: Shrirang Bagul <shrirang.bagul@canonical.com>, bjorn@mork.no
Cc: johan@kernel.org, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: qmi_wwan: add Dell DW5818, DW5819
Date: Mon, 20 Nov 2017 17:28:02 +0700 [thread overview]
Message-ID: <d3017780-2d79-6f88-704d-b6dec85beb71@gmail.com> (raw)
In-Reply-To: <20171120092759.17981-1-shrirang.bagul@canonical.com>
On 11/20/2017 16:27, Shrirang Bagul wrote:
> Dell Wireless 5819/5818 devices are re-branded Sierra Wireless MC74
> series modems which will by default boot with vid 0x413c and pid's
> 0x81cf, 0x81d0, 0x81d1,0x81d2. Along with qcserial, these modems support
> qmi_wwan on the usb interface #12.
>
> Signed-off-by: Shrirang Bagul <shrirang.bagul@canonical.com>
> ---
> drivers/net/usb/qmi_wwan.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 8d4a6f7cba61..bdf1fae38af2 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1234,6 +1234,10 @@ static const struct usb_device_id products[] = {
> {QMI_FIXED_INTF(0x413c, 0x81b3, 8)}, /* Dell Wireless 5809e Gobi(TM) 4G LTE Mobile Broadband Card (rev3) */
> {QMI_FIXED_INTF(0x413c, 0x81b6, 8)}, /* Dell Wireless 5811e */
> {QMI_FIXED_INTF(0x413c, 0x81b6, 10)}, /* Dell Wireless 5811e */
> + {QMI_FIXED_INTF(0x413c, 0x81cf, 12)}, /* Dell Wireless 5819 */
> + {QMI_FIXED_INTF(0x413c, 0x81d0, 12)}, /* Dell Wireless 5819 */
> + {QMI_FIXED_INTF(0x413c, 0x81d1, 12)}, /* Dell Wireless 5818 */
> + {QMI_FIXED_INTF(0x413c, 0x81d2, 12)}, /* Dell Wireless 5818 */
> {QMI_FIXED_INTF(0x03f0, 0x4e1d, 8)}, /* HP lt4111 LTE/EV-DO/HSPA+ Gobi 4G Module */
> {QMI_FIXED_INTF(0x22de, 0x9061, 3)}, /* WeTelecom WPD-600N */
> {QMI_FIXED_INTF(0x1e0e, 0x9001, 5)}, /* SIMCom 7230E */
>
NAK
413c:81cf and 413c:81d1 do not have a net interface, they only have a
single serial interface (QDL) for firmware update.
Please do not add usb id's for which you have not confirmed the
interface composition.
br
Lars
prev parent reply other threads:[~2017-11-20 10:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 9:27 [PATCH] net: qmi_wwan: add Dell DW5818, DW5819 Shrirang Bagul
2017-11-20 9:41 ` Bjørn Mork
2017-11-20 10:01 ` Shrirang Bagul
2017-11-20 10:28 ` Lars Melin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3017780-2d79-6f88-704d-b6dec85beb71@gmail.com \
--to=larsm17@gmail.com \
--cc=bjorn@mork.no \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shrirang.bagul@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox