From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751179AbdKTK3N (ORCPT ); Mon, 20 Nov 2017 05:29:13 -0500 Received: from mail-it0-f65.google.com ([209.85.214.65]:37802 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750952AbdKTK2I (ORCPT ); Mon, 20 Nov 2017 05:28:08 -0500 X-Google-Smtp-Source: AGs4zMbiWVex5FsnKxkCyw44fY0KwBOmth4S2DiXkDDwFFtY+pOcBdkMABDOvqO0iAd3tWK6R1cfIg== Subject: Re: [PATCH] net: qmi_wwan: add Dell DW5818, DW5819 To: Shrirang Bagul , bjorn@mork.no Cc: johan@kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171120092759.17981-1-shrirang.bagul@canonical.com> From: Lars Melin Message-ID: Date: Mon, 20 Nov 2017 17:28:02 +0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171120092759.17981-1-shrirang.bagul@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/20/2017 16:27, Shrirang Bagul wrote: > Dell Wireless 5819/5818 devices are re-branded Sierra Wireless MC74 > series modems which will by default boot with vid 0x413c and pid's > 0x81cf, 0x81d0, 0x81d1,0x81d2. Along with qcserial, these modems support > qmi_wwan on the usb interface #12. > > Signed-off-by: Shrirang Bagul > --- > drivers/net/usb/qmi_wwan.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c > index 8d4a6f7cba61..bdf1fae38af2 100644 > --- a/drivers/net/usb/qmi_wwan.c > +++ b/drivers/net/usb/qmi_wwan.c > @@ -1234,6 +1234,10 @@ static const struct usb_device_id products[] = { > {QMI_FIXED_INTF(0x413c, 0x81b3, 8)}, /* Dell Wireless 5809e Gobi(TM) 4G LTE Mobile Broadband Card (rev3) */ > {QMI_FIXED_INTF(0x413c, 0x81b6, 8)}, /* Dell Wireless 5811e */ > {QMI_FIXED_INTF(0x413c, 0x81b6, 10)}, /* Dell Wireless 5811e */ > + {QMI_FIXED_INTF(0x413c, 0x81cf, 12)}, /* Dell Wireless 5819 */ > + {QMI_FIXED_INTF(0x413c, 0x81d0, 12)}, /* Dell Wireless 5819 */ > + {QMI_FIXED_INTF(0x413c, 0x81d1, 12)}, /* Dell Wireless 5818 */ > + {QMI_FIXED_INTF(0x413c, 0x81d2, 12)}, /* Dell Wireless 5818 */ > {QMI_FIXED_INTF(0x03f0, 0x4e1d, 8)}, /* HP lt4111 LTE/EV-DO/HSPA+ Gobi 4G Module */ > {QMI_FIXED_INTF(0x22de, 0x9061, 3)}, /* WeTelecom WPD-600N */ > {QMI_FIXED_INTF(0x1e0e, 0x9001, 5)}, /* SIMCom 7230E */ > NAK 413c:81cf and 413c:81d1 do not have a net interface, they only have a single serial interface (QDL) for firmware update. Please do not add usb id's for which you have not confirmed the interface composition. br Lars