public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Linus Walleij" <linus.walleij@linaro.org>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Cc: "Oliver Neukum" <oneukum@suse.com>,
	"Ye Xiang" <xiang.ye@intel.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Matthias Kaehlcke" <mka@chromium.org>,
	"Lee Jones" <lee@kernel.org>, "Wolfram Sang" <wsa@kernel.org>,
	"Tyrone Ting" <kfting@nuvoton.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	linux-usb@vger.kernel.org, linux-i2c@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	srinivas.pandruvada@intel.com, heikki.krogerus@linux.intel.com,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	zhifeng.wang@intel.com, wentong.wu@intel.com,
	lixu.zhang@intel.com
Subject: Re: [PATCH v4 2/5] gpio: Add support for Intel LJCA USB GPIO driver
Date: Thu, 09 Mar 2023 15:48:47 +0100	[thread overview]
Message-ID: <d307b36e-4901-458d-a366-eaf478a77412@app.fastmail.com> (raw)
In-Reply-To: <CACRpkdYQfT=JXvmjKR_9O74H2dmwx1EF4QjCHM6fKAetpbrMOg@mail.gmail.com>

On Thu, Mar 9, 2023, at 15:18, Linus Walleij wrote:
> On Thu, Mar 9, 2023 at 2:53 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
>
> Yups. And I think the solution looks something like this:
>
> u8 obuf[LJCA_GPIO_BUF_SIZE] __aligned(8);
> u8 ibuf[LJCA_GPIO_BUF_SIZE] __aligned(8);
>
> __aligned(4) if it's 32bit DMA I guess? 8 always works that's
> why we use it all over the IIO subsystem.

I think it must be __aligned(ARCH_DMA_MINALIGN), to account
for architectures with non-coherent DMA.

     Arnd

  parent reply	other threads:[~2023-03-09 14:51 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-09  7:10 [PATCH v4 0/5] Add Intel LJCA device driver Ye Xiang
2023-03-09  7:10 ` [PATCH v4 1/5] mfd: Add support for Intel LJCA device Ye Xiang
2023-03-09  7:49   ` Greg Kroah-Hartman
2023-03-09  9:10     ` Ye, Xiang
2023-03-09  9:26       ` Greg Kroah-Hartman
2023-03-09 10:16         ` Ye, Xiang
2023-03-09  7:52   ` Greg Kroah-Hartman
2023-03-09  9:31     ` Ye, Xiang
2023-03-09  9:41       ` Greg Kroah-Hartman
2023-03-09 10:06         ` Andi Shyti
2023-03-09 15:45           ` Ye, Xiang
2023-03-09 15:58             ` Greg Kroah-Hartman
2023-03-09 17:42               ` Ye, Xiang
2023-03-09  7:56   ` Arnd Bergmann
2023-03-09 10:00     ` Ye, Xiang
2023-03-09 11:03     ` Mark Brown
2023-03-09 11:30       ` Arnd Bergmann
2023-03-09 12:53   ` Oliver Neukum
2023-03-10  4:14     ` Ye, Xiang
2023-03-13 13:27       ` Oliver Neukum
2023-03-14  7:15         ` Ye, Xiang
2023-03-09  7:10 ` [PATCH v4 2/5] gpio: Add support for Intel LJCA USB GPIO driver Ye Xiang
2023-03-09 13:40   ` Oliver Neukum
2023-03-09 13:52     ` Andy Shevchenko
2023-03-09 14:06       ` Greg Kroah-Hartman
2023-03-09 14:18       ` Linus Walleij
2023-03-09 14:36         ` Greg Kroah-Hartman
2023-03-09 14:48         ` Arnd Bergmann [this message]
2023-03-09 17:37           ` Oliver Neukum
2023-03-09 17:30       ` Oliver Neukum
2023-03-10  5:01     ` Ye, Xiang
2023-03-10  7:11       ` Greg Kroah-Hartman
2023-03-10  7:39         ` Ye, Xiang
2023-03-10  7:53           ` Greg Kroah-Hartman
2023-03-10  8:59             ` Ye, Xiang
2023-03-11 12:13   ` Krzysztof Kozlowski
2023-03-12 15:40     ` Ye, Xiang
2023-03-09  7:10 ` [PATCH v4 3/5] i2c: Add support for Intel LJCA USB I2C driver Ye Xiang
2023-03-09  7:10 ` [PATCH v4 4/5] spi: Add support for Intel LJCA USB SPI driver Ye Xiang
2023-03-09  7:11 ` [PATCH v4 5/5] Documentation: Add ABI doc for attributes of LJCA device Ye Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d307b36e-4901-458d-a366-eaf478a77412@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=brgl@bgdev.pl \
    --cc=broonie@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=kfting@nuvoton.com \
    --cc=lee@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lixu.zhang@intel.com \
    --cc=mka@chromium.org \
    --cc=oneukum@suse.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=srinivas.pandruvada@intel.com \
    --cc=wentong.wu@intel.com \
    --cc=wsa@kernel.org \
    --cc=xiang.ye@intel.com \
    --cc=zhifeng.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox