From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D94E41B4F3E for ; Tue, 15 Oct 2024 07:52:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.191 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728978733; cv=none; b=iF3ODGoJ35dEZKkGFTYib/0Nja/IV9vnPTKtyR3wxQqBgGV5xQdPGeFB1Kd9LOY7M2ExGo9yj4obQ3J03Gs0pYWNlFlKq7VmGjdS0gUo2WPs8XgBgZSzKcxlme3eFOL/fzl9gBLFWG1luo09PYOHTz44ODvFlVZ1PD4qAcSdKBA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728978733; c=relaxed/simple; bh=mMBF0bybCnBv6xfZH8e7a1EYIWo0H6TAcmc0BZbtBJc=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=B/RgnSIgIywIOeZ1HZUeEREFyNDsUQKpTpOwwk8Z6PDcXl5L6/0UFiuLy7o9Nlco78hAdtf62tFn2x8jCKnkcvGYB4A0smAbGGVmihgIDG40nyN7SDXn3SeBQ+XsnqVkxrsolc0ayKKM8JKUMyLfcd8a0BMekHGAZ++Jf4T0h/Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.191 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4XSR640dfQz1HKpS; Tue, 15 Oct 2024 15:47:56 +0800 (CST) Received: from kwepemh500013.china.huawei.com (unknown [7.202.181.146]) by mail.maildlp.com (Postfix) with ESMTPS id 318021402CA; Tue, 15 Oct 2024 15:52:08 +0800 (CST) Received: from [10.67.109.254] (10.67.109.254) by kwepemh500013.china.huawei.com (7.202.181.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 15 Oct 2024 15:52:07 +0800 Message-ID: Date: Tue, 15 Oct 2024 15:52:06 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH] drm/panel: s6e3ha8: select CONFIG_DRM_DISPLAY_DSC_HELPER Content-Language: en-US To: Arnd Bergmann , Neil Armstrong , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dzmitry Sankouski CC: Arnd Bergmann , Jessica Zhang , Dmitry Baryshkov , , References: <20241015073115.4128727-1-arnd@kernel.org> From: Jinjie Ruan In-Reply-To: <20241015073115.4128727-1-arnd@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemh500013.china.huawei.com (7.202.181.146) On 2024/10/15 15:30, Arnd Bergmann wrote: > From: Arnd Bergmann > > The new driver needs the dsc helper code to be available: > > x86_64-linux-ld: vmlinux.o: in function `s6e3ha8_amb577px01_wqhd_prepare': > panel-samsung-s6e3ha8.c:(.text+0x16b1e65): undefined reference to `drm_dsc_pps_payload_pack' > > Select it from Kconfig as we do for other similar drivers. > > Fixes: 779679d3c164 ("drm/panel: Add support for S6E3HA8 panel driver") > Signed-off-by: Arnd Bergmann > --- > drivers/gpu/drm/panel/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index ddfaa99ea9dd..ffe7eff71496 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -626,6 +626,7 @@ config DRM_PANEL_SAMSUNG_AMS639RQ08 > config DRM_PANEL_SAMSUNG_S6E88A0_AMS452EF01 > tristate "Samsung AMS452EF01 panel with S6E88A0 DSI video mode controller" > depends on OF > + select DRM_DISPLAY_DSC_HELPER It seems that it uses DRM_DISPLAY_DP_HELPER in mainline but use DRM_DISPLAY_DSC_HELPER in next. > select DRM_MIPI_DSI > select VIDEOMODE_HELPERS >