Re: [PATCH] drm/panel: s6e3ha8: select CONFIG_DRM_DISPLAY_DSC_HELPER

Jinjie Ruan
2024-10-15T07:52:10Z

On 2024/10/15 15:30, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The new driver needs the dsc helper code to be available:
>
> x86_64-linux-ld: vmlinux.o: in function `s6e3ha8_amb577px01_wqhd_prepare':
> panel-samsung-s6e3ha8.c:(.text+0x16b1e65): undefined reference to `drm_dsc_pps_payload_pack'
>
> Select it from Kconfig as we do for other similar drivers.
>
> Fixes: 779679d3c164 ("drm/panel: Add support for S6E3HA8 panel driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/panel/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index ddfaa99ea9dd..ffe7eff71496 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -626,6 +626,7 @@ config DRM_PANEL_SAMSUNG_AMS639RQ08
> config DRM_PANEL_SAMSUNG_S6E88A0_AMS452EF01
> tristate "Samsung AMS452EF01 panel with S6E88A0 DSI video mode controller"
> depends on OF
> + select DRM_DISPLAY_DSC_HELPER

It seems that it uses DRM_DISPLAY_DP_HELPER in mainline but use
DRM_DISPLAY_DSC_HELPER in next.

> select DRM_MIPI_DSI
> select VIDEOMODE_HELPERS
>