From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 814472EC541 for ; Fri, 19 Dec 2025 10:49:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766141377; cv=none; b=lPhPgC0Zvo1Sn/kXiAEsbvGerNX7Zn+VQWVgXZeCHOnMaPgQZ3RY0J8pNK9ee2OfH/N3/zuZpzVpqRcKXSqd5GtfsyqE9rKPg2JELkSfCRW53EymW5ZokOmH4drsoW+matrocNxiTSOzNAt16S54pkT4CW81FEJuSLBjckL7KnM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766141377; c=relaxed/simple; bh=x+6xRYk2Op/6++Z1R5ZwUV0nU/AQUyfZG/1FG4LXnto=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tHa7KvuR7eF8yrJp5IYH3fb83f/GEnQ525eQF/Vt2tTUATymYaKcoi/yRyDArcjTCQiPu9Wsz+P8vy2NC6CdTcuDHXN6tgMY2fJv/nYmUL66DHsXarVWbTLVE53CZt7UZF0kbOuYhaNAKPYuS7AvlfEK0RGWixIKWjXFXek17Sc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mLBNPlAK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XH5xhVkT; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mLBNPlAK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XH5xhVkT" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BJ4cJx43700755 for ; Fri, 19 Dec 2025 10:49:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VIZ8jughWqh2XZFb1D2e0pMbJxJANlZrbN6DOS5EpsU=; b=mLBNPlAKG3xJMruu 8995kfM27Oz7GGwUZfyHYAlthfNV3COUpKUwMiYch0cIV1dvN3sxGOt0L6J0Gpfr TIMDdclShvMeEZ/va6Mx5Q8yT9RL3RjQoK6SGQ4xFbqoq1Z5aWvLew0cXb8+m80R nGqGskNMFQe9WPhFTQb9WoU3fuIuK5RxqKsDCAhQG5k3tQTw0NWZblDxgUGy633q qLlRWnAWI/DI9BaJFYzjBD0lRCPS9hs81ftdzkcb39VQmAItM15W7UZf4lAfg8cy 2V+vn4Hb9AzuBQ3R+hh+0qYcWawBoKBflfntmEqxrbbrjoTa703OHQp26f2RMCCs MC7L3Q== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b4r2ejas3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 19 Dec 2025 10:49:34 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4edaa289e0dso3873691cf.3 for ; Fri, 19 Dec 2025 02:49:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766141374; x=1766746174; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VIZ8jughWqh2XZFb1D2e0pMbJxJANlZrbN6DOS5EpsU=; b=XH5xhVkTMYak1uzFm/EDjKkMxHvKk6Z7rT6D9mYiTUZwlIPsftPSTIc1/efS1c6T7N sNyMoBAIeY7z552j50jMH8BtmgpGuC2P6BZonx2ttY36bq67kRLNURsjjU1H0c31Y2IY f62dVdKvpbjZoVAshbtHsSMh4ayPQyVW8RBWFXoQq+gZp2M0GZVeiQVJbRlIAqKmPn6V 5dLIzSlnIQFw+BKn+Yq5O0pKG3lEe7HMU3+pVWimwh7Vu5Y3Db5jc0H8/JeTrmhx+Nkh abrP7DIrIDnfV5Gf9ZCv0clVdE21lX9BvUESHqqDEe9uxFeDwybEMc6TAAHS8LM/fcAC 5OSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766141374; x=1766746174; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VIZ8jughWqh2XZFb1D2e0pMbJxJANlZrbN6DOS5EpsU=; b=v/ddZG2hnvIuucWaM818YmUsjUguJudjpT2e5I8ygiqbSEhI0UeLV2NIAjbmcKD7M1 vwXzG1U6m23vT+7+zy0JsZeijTohzlT32wroXZDWd9uBO8jK9U8lD+3UdZCu3hirKMwG XYopq1TfBIQ+a+m8+ovr01P9vCj8KNIKFb/z/k8Ggf5a8VBccXlTYNziZExgbkowkqJK BzPe/VIrrh3XwI+ckD9Porw2DIaQFDMGt3CuSkNPtEMMxTEu871zWh49NanSr8RwMTA9 lUgNDhzGXSuhnb9bHzjZOC6ZXiQOtXdBHxEQZ1Vm0vrYPEGkIZ0Yf0rsQHKfgD5NbTmW Xxbg== X-Forwarded-Encrypted: i=1; AJvYcCUOPypYYC0zC7UUCyjU5BvN8sRj78N1lqNqg0e3kejkj5G9ZM37Qns5nJxM3SkP8s5x+omOCWqg0x9Oiqo=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9oF4XEQo1ya9E/1WzEBg7Z4rYgwUI/1+7v8yAJfzz9A2eDgtK 3Y2sQZfEpbeE4Ic+bFwRnBzabrmq6WoLElO/jV3PsdQe1aUmcCvHXP8ofSYMahR5WT0vnu2RFF6 dkbSHZLsnQhZmTtLS8WvEBEJ4ljbMjWKIrBN7ivxAo4ktt6TijPkhBi4mjZIze6zEvF4= X-Gm-Gg: AY/fxX7e783LaD8vVyytq4pOrvktRk9NInNzUXzDgvSC/VMhonFLhD2PSvOh9WTVPKc krfKbwm9FlHZ5tE+f6sbkP3IWXZ3C2XCXPvm8s0Bc0NiCpbhO++wRNzmtJ0ZLB7cOhzFo3eaPcy e6fV3QH5sd9f6B0cqtiOSf2PRC/JIi8xgqC6lllIlxmmhWhOaFYDI8hXxPrjvnO080qq11gmkg4 TbN9mfxdR3N/r0lNB9fTB63vOdnDhkaZhHXF/5ggBDDjknHm5PUQlMydJzJe6h88A8BVZOb7k3K F/osLlYTxbJaa6nonaOky0TZYryqfd8GZO6a0ngpRxV1v7RA5QtGUiZoYS1o9gNeDfuY4v8ridQ ZK0wfazFAe0bii+7bdMgKKi46E5JTF1VeWPHZBYBlpoBgn8Bau3z0AqMz7u8cq+0iDw== X-Received: by 2002:a05:622a:249:b0:4ee:1e33:bc45 with SMTP id d75a77b69052e-4f4abd3d611mr26268431cf.5.1766141373664; Fri, 19 Dec 2025 02:49:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IE+sBoG00UDaquXtdH6OeQuyKlRB28buLCPRAdJtRH7LIm0VSc1uk9ZDHxp5K9RnmC++71xLw== X-Received: by 2002:a05:622a:249:b0:4ee:1e33:bc45 with SMTP id d75a77b69052e-4f4abd3d611mr26268201cf.5.1766141373158; Fri, 19 Dec 2025 02:49:33 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b9105a9c4sm1896474a12.12.2025.12.19.02.49.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Dec 2025 02:49:32 -0800 (PST) Message-ID: Date: Fri, 19 Dec 2025 11:49:30 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: sdm845-oneplus: Enable known blocks and add placeholders To: David Heidelberg , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org References: <20251216-placeholders-v1-1-d7d544200e7c@ixit.cz> <5199fe6a-550a-4366-bee2-d4ab08ed248b@ixit.cz> <5f1282b2-2447-4ce8-a943-90c88e7f5835@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: KHiQnQcgOYCBzGH6Oj_QfIzcoZvLmYUj X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE5MDA4OSBTYWx0ZWRfX9hay7gPgx4Hn aEZpUZ+i4rtVq61QyTo0b2oguRJqQCxvhED/xNsrIAwsGGVvOGZGOjxMd9qkb7tTrGz4WV8/MVr 7kuI2+xUJnH4fZAF8NGsuZwjetttSyBhCLLPvHCyk7enORexOBKg/ck92kyryahxf1lF9uE17b1 7IoMx88EewAGvZacujvXJRQawCNaqGD1VoKcoadpRdPHoqM1xknkqINM20bUCYOsuIxesInW8Ru +qT1Z5ige40CeHJp/+A0Dg8l/SKXgnKkHjmTuhPDdPQ6kTX5hGiJd6GCvClnCGI6yBaYQC2pJwY 8zglLKXlEjb1wA9JTsEH47JLGjiXRdN2MfiaYX/eSh5f9hL62Gz61BsxmYguF/1vNeShjD25mYK fVsME0L9yjK9ojMxOizgkOalbrdUUrDUH2QmX5tuxXUDiFCLdwqBDw5B1DNV4KUzOTfKbyp1s8g BOXizSPVat2KpnFMgiA== X-Proofpoint-ORIG-GUID: KHiQnQcgOYCBzGH6Oj_QfIzcoZvLmYUj X-Authority-Analysis: v=2.4 cv=EabFgfmC c=1 sm=1 tr=0 ts=69452dbe cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=p0WdMEafAAAA:8 a=KDegXbQYsfhHM6AYP-QA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-19_03,2025-12-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 suspectscore=0 priorityscore=1501 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512190089 On 12/18/25 11:30 PM, David Heidelberg wrote: > On 17/12/2025 16:28, Konrad Dybcio wrote: >> On 12/17/25 4:00 PM, David Heidelberg wrote: >>> On 17/12/2025 13:04, Konrad Dybcio wrote: >>>> On 12/16/25 9:34 PM, David Heidelberg via B4 Relay wrote: >>>>> From: David Heidelberg >>>>> >>>>> We know these devices are present; most of them are supported by >>>>> downstream and are close to the mainline kernels. >>>>> >>>>> This adds placeholders for: >>>>>    - front camera (imx371) >>>>>    - rear cameras (imx519, imx376k) >>>>>    - actuators >>>>>    - NFC node on i2c3 >>>>> >>>>> This is very handy when rebasing the integration tree with >>>>> support for multiple different blocks at the same time. >>>>> >>>>> Signed-off-by: David Heidelberg >>>>> --- >>>> >>>> [...] >>>> >>>>> +&i2c3 { >>>>> +    clock-frequency = <400000>; >>>>> + >>>>> +    status = "okay"; >>>>> + >>>>> +    /* nxp,nxp-nci-i2c @28 */ >>>> >>>> This seems fairly straightforward to enable - could you just >>>> do that instead? >>> >>> I have patch for it in-tree, but most likely not correct. See notes in: >>> >>> https://gitlab.com/sdm845/sdm845-next/-/commit/eeb765bb1166e020a771ed712fec76b56da229ee >>> >>> For now, I can only confirm the device is on the i2c address. >> >> Taking a look at just the names of the sdm845-qrd.dtsi/sony modifications for >> their sdm845 phones in downstream which I presume have the exact same chip anyway: >> >> notes based on observation and driver (drivers/nfc/nq-nci.c) >> >>          nq@28 { >>                  compatible = "qcom,nq-nci"; >>                  reg = <0x28>; >>                  qcom,nq-irq = <&tlmm 63 0x00>; // interrupt, duplicated below >>                  qcom,nq-ven = <&tlmm 12 0x00>; // voltage enable, ACTIVE_HIGH >>                  qcom,nq-firm = <&tlmm 62 0x00>; // firmware download, ACTIVE_HIGH >>                  qcom,nq-clkreq = <&pm8998_gpios 21 0x00>; // clock enable, INPUT >>                  qcom,nq-esepwr = <&tlmm 116 0x00>; // eSE power enable, ACTIVE_HIGH >>                  interrupt-parent = <&tlmm>; >>                  interrupts = <63 0>; >>         [... blurb ...] >>          }; >> >> >>     pm8998_gpio_21: pm8998_gpio_21 { >>                  pins = "gpio21"; >>                  function = "normal"; >>                  input-enable; >>                  bias-pull-down; >>                  power-source = <1>; >>          }; >> >> >>          /* GPIO_62: NFC_DWLD_EN */ >>          sdm_gpio_62: sdm_gpio_62 { >>                  mux { >>                          pins = "gpio62"; >>                          function = "gpio"; >>                  }; >> >>                  config { >>                          pins = "gpio62"; >>                          drive-strength = <2>; >>                          bias-disable; >>                          output-low; >>                  }; >>          }; >> >> >>          /* GPIO_63: NFC_IRQ */ >>          sdm_gpio_63: sdm_gpio_63 { >>                  mux { >>                          pins = "gpio63"; >>                          function = "gpio"; >>                  }; >> >>                  config { >>                          pins = "gpio63"; >>                          drive-strength = <2>; >>                          bias-pull-down; >>                          input-enable; >>                  }; >>          }; >> >> >>          /* GPIO_12 : NFC_VEN */ >>          sdm_gpio_12: sdm_gpio_12 { >>                  mux { >>                          pins = "gpio12"; >>                          function = "gpio"; >>                  }; >> >>                  config { >>                          pins = "gpio12"; >>                          drive-strength = <2>; >>                          bias-disable; >>                          output-low; >>                  }; >>          }; >> >> Konrad > > we have something similar, just different strengths (see below), but I would leave this into the point, when someone can properly verify the configuration and test it. You *really* need to configure the PMIC GPIO explicitly Konrad