From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70CE42C859 for ; Wed, 15 Apr 2026 02:06:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776218793; cv=none; b=BsnDl6Nw+Acax6U6i1eblsXE4qRzsf0r3ty7CXI5logXM+tL6TcFWMgrwA49vZMtKCXMaR5ZP5Jt8p25qT+hP4GhFiT2fAdi3a2lkrMnx8EAakqWmJs5a5d2IrjpQgN2cVMPg8Fh1tsaXIlhAo7aiUQ/8EUWX1xlI64S0gzactg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776218793; c=relaxed/simple; bh=wrPhtXBTaIZ8n5auWmKEqYCeajJmghFT1WeRrnKaIFI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YDjy1sgl/61+Q4u2ATt3uYtqQOXooJA5Gx1AqagXPoXuWOWVmJY0NATST9tH6PiY4Ag+7hCavb0OPytE4VNk8hnB3UBVst4ME4n/txTs1sgBUfeLPSMVIdNwJyMi+ZI1VoTcp1RBIBnf+X514SzTUFU8bQCZQgDa1GIwSBgj31c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=O9Vb+PIk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="O9Vb+PIk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3EB00C19425; Wed, 15 Apr 2026 02:06:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776218793; bh=wrPhtXBTaIZ8n5auWmKEqYCeajJmghFT1WeRrnKaIFI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=O9Vb+PIkUQqTLoT8BXzdxs53f7IgCa1Si1+RDST2lxRhV9PCz5L9zzqt65UAxTK+O nMJS0RGVyyFXpjx4UZPXWMurEVtOaZnO9uoX3r1Nj3CqPr+lq8XDi62CSwwLUbZr2e Qbd3YcfTxIYPW6ad00zZW/solNDl7burQnYAx7CvbY37CURkRVMnF7BLmOCKuaaCs2 OOoH0Tlnp3fIaGpF2ADjmrRBAdKbxGdIqE+JRxPu/Q5D3JTP0Ygn2S0d09wZKW/JBF 7yVzhL2bNEVO6YtZ2Q3RCMVtUDDZch1P4YHSkn/1EOazHVjXCTfasp9dL9cyYUv9Za C+EuPJvvTOdyw== Message-ID: Date: Wed, 15 Apr 2026 12:06:28 +1000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] riscv: smp: Align secondary_start_sbi to 4 bytes To: cp0613@linux.alibaba.com, pjw@kernel.org, anup@brainfault.org, andrew.jones@oss.qualcomm.com, guoren@kernel.org Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260413132009.133752-1-cp0613@linux.alibaba.com> Content-Language: en-US From: Michael Ellerman In-Reply-To: <20260413132009.133752-1-cp0613@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/4/2026 23:20, cp0613@linux.alibaba.com wrote: > From: Chen Pei > > During SMP boot, the secondary_start_sbi address is passed to the > slave core via sbi_hsm_hart_start. In OpenSBI, this address is > written to STVEC in sbi_hart_switch_mode. ... > diff --git a/arch/riscv/kernel/head.S b/arch/riscv/kernel/head.S > index 9c99c5ad6fe8..9f33be6260e1 100644 > --- a/arch/riscv/kernel/head.S > +++ b/arch/riscv/kernel/head.S > @@ -127,6 +127,7 @@ relocate_enable_mmu: > #endif /* CONFIG_MMU */ > #ifdef CONFIG_SMP > .global secondary_start_sbi > + .align 2 > secondary_start_sbi: > /* Mask all interrupts */ > csrw CSR_IE, zero Minor nit, but IMHO .balign is preferable in new code. It always byte aligns, whereas .align has different meanings across architectures, and on some arches (including riscv) requires the reader to do the math to convert to a byte alignment. These days there's also the SYM_CODE_START etc. macros defined via linkage.h, which use __ALIGN from arch/riscv/include/asm/linkage.h, which is already .balign 4. cheers