From: Jes Sorensen <jes@linuxcare.com>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: Ion Badulescu <ionut@cs.columbia.edu>,
Jeff Garzik <jgarzik@mandrakesoft.com>,
Alan Cox <alan@redhat.com>,
linux-kernel@vger.kernel.org, Donald Becker <becker@scyld.com>
Subject: Re: [PATCH] starfire reads irq before pci_enable_device.
Date: 09 Feb 2001 22:43:53 +0100 [thread overview]
Message-ID: <d38znfwmzq.fsf@lxplus015.cern.ch> (raw)
In-Reply-To: <Pine.LNX.4.30.0102081259090.31024-100000@age.cs.columbia.edu> <3A831313.A23EE2A1@colorfullife.com>
In-Reply-To: Manfred Spraul's message of "Thu, 08 Feb 2001 22:43:47 +0100"
>>>>> "Manfred" == Manfred Spraul <manfred@colorfullife.com> writes:
Manfred> Ion Badulescu wrote:
>> > > +#if defined(__ia64__) || defined(__alpha__) > > +#define
>> PKT_SHOULD_COPY(pkt_len) 1 > > +#else > > +#define
>> PKT_SHOULD_COPY(pkt_len) (pkt_len < rx_copybreak) > > +#endif >
>> [snip]
>>
>> It's not *required* per se, as far as I know both the Alpha and
>> IA64 have handlers for unaligned access traps. *However*, copying
>> each packet is definitely better than taking an exception for each
>> packet!
Manfred> What about changing the default for rx_copybreak instead?
Manfred> Set it to 1536 on ia64 and Alpha, 0 for the rest. tulip and
Manfred> eepro100 use that aproach.
Inefficient, my patch will make the unused code path disappear during
compilation, what you suggest results in an extra branch and unused
code.
The eepro100 and tulip drivers really should be changed to use the
same trick.
Jes
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2001-02-09 21:45 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-07 19:52 [PATCH] starfire reads irq before pci_enable_device davej
2001-02-07 19:57 ` Jeff Garzik
2001-02-07 20:34 ` Manfred Spraul
2001-02-08 4:00 ` Jeff Garzik
2001-02-08 1:52 ` Ion Badulescu
2001-02-08 20:28 ` Jeff Garzik
2001-02-08 21:18 ` Ion Badulescu
2001-02-08 21:38 ` Jeff Garzik
2001-02-08 22:05 ` Ion Badulescu
2001-02-09 19:08 ` Jeff Garzik
2001-02-09 20:07 ` Ion Badulescu
2001-02-09 20:11 ` Jeff Garzik
2001-02-09 20:21 ` Ion Badulescu
2001-02-09 20:26 ` Jeff Garzik
2001-02-08 21:43 ` Manfred Spraul
2001-02-08 21:46 ` Ion Badulescu
2001-02-09 21:43 ` Jes Sorensen [this message]
2001-02-09 21:52 ` Ion Badulescu
2001-02-12 18:54 ` Jes Sorensen
2001-02-14 1:35 ` Ion Badulescu
2001-02-10 14:48 ` Manfred Spraul
2001-02-08 21:26 ` Donald Becker
2001-02-08 22:16 ` Ion Badulescu
2001-02-09 0:09 ` Ion Badulescu
2001-02-09 0:44 ` Donald Becker
2001-02-09 0:47 ` Ion Badulescu
2001-02-09 10:49 ` Alan Cox
2001-02-09 23:32 ` Ion Badulescu
2001-02-09 23:35 ` Alan Cox
2001-02-10 8:48 ` Gérard Roudier
2001-02-12 19:01 ` Jes Sorensen
2001-02-13 13:06 ` Jeff Garzik
2001-02-13 20:29 ` Ion Badulescu
2001-02-14 2:05 ` Ion Badulescu
2001-02-14 20:10 ` Gérard Roudier
2001-02-14 15:39 ` Jes Sorensen
2001-02-17 21:34 ` David S. Miller
2001-02-19 11:00 ` Jes Sorensen
2001-02-09 21:42 ` Jes Sorensen
2001-02-09 22:56 ` Donald Becker
2001-02-12 18:54 ` Jes Sorensen
2001-02-14 1:20 ` Donald Becker
2001-02-14 12:37 ` Alan Cox
2001-02-14 12:49 ` Jeff Garzik
2001-02-14 12:54 ` Ion Badulescu
2001-02-14 13:05 ` Alan Cox
2001-02-14 13:38 ` Ion Badulescu
2001-02-14 15:35 ` Jes Sorensen
-- strict thread matches above, loose matches on Subject: below --
2001-02-14 16:54 Petr Vandrovec
2001-02-15 16:09 ` Jes Sorensen
2001-02-07 18:42 davej
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d38znfwmzq.fsf@lxplus015.cern.ch \
--to=jes@linuxcare.com \
--cc=alan@redhat.com \
--cc=becker@scyld.com \
--cc=ionut@cs.columbia.edu \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox