From: Andrew Lunn <andrew@lunn.ch>
To: Daniel Golle <daniel@makrotopia.org>
Cc: Xu Liang <lxu@maxlinear.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] net: phy: mxl-86110: add basic support for led_brightness_set op
Date: Fri, 15 Aug 2025 19:25:34 +0200 [thread overview]
Message-ID: <d3a0eb3b-933f-4451-801a-e8ceb17f5953@lunn.ch> (raw)
In-Reply-To: <aJ9hUhVfzyvJK8Rt@pidgin.makrotopia.org>
> + phy_lock_mdio_bus(phydev);
> +
> + ret = __mxl86110_modify_extended_reg(phydev,
> + MXL86110_COM_EXT_LED_GEN_CFG,
> + MXL86110_COM_EXT_LED_GEN_CFG_LFE(index),
> + 0);
> +
> + phy_unlock_mdio_bus(phydev);
Please add a mxl86110_modify_extended_reg() which does the
locking. There is already mxl86110_write_extended_reg() and
mxl86110_read_extended_reg().
Andrew
---
pw-bot: cr
prev parent reply other threads:[~2025-08-15 17:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 16:33 [PATCH net-next 1/2] net: phy: mxl-86110: add basic support for led_brightness_set op Daniel Golle
2025-08-15 17:25 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3a0eb3b-933f-4451-801a-e8ceb17f5953@lunn.ch \
--to=andrew@lunn.ch \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lxu@maxlinear.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox