[patch] Acenic tigon 1 support fix

[patch] Acenic tigon 1 support fix

[Olivier Galibert]

A typo prevents the tigon 1 firmware to be included when tigon 1
support is active.  Null pointer dereference in
ace_load_firmware->ace_copy as a result.

Patch trivial and even tested (aka, the module loads without oopsing
with a tigon 1 inside).

  OG.

--- linux/drivers/net/acenic_firmware.h	Tue Mar  6 22:28:33 2001
+++ linux-2.4.4/drivers/net/acenic_firmware.h	Mon Apr 30 16:51:25 2001
@@ -17,7 +17,7 @@
 #define tigonFwSbssLen 0x38
 #define tigonFwBssAddr 0x00015dd0
 #define tigonFwBssLen 0x2080
-#ifndef CONFIG_ACENIC_OMIT_TIGON_I
+#ifdef CONFIG_ACENIC_OMIT_TIGON_I
 #define tigonFwText 0
 #define tigonFwData 0
 #define tigonFwRodata 0

Re: [patch] Acenic tigon 1 support fix

[Jes Sorensen]

>>>>> "Olivier" == Olivier Galibert <galibert@pobox.com> writes:

Olivier> A typo prevents the tigon 1 firmware to be included when
Olivier> tigon 1 support is active.  Null pointer dereference in
Olivier> ace_load_firmware-> ace_copy as a result.

Olivier> Patch trivial and even tested (aka, the module loads without
Olivier> oopsing with a tigon 1 inside).

Thanks, I'll put that in the next driver release as well.

Jes

Re: [patch] Acenic tigon 1 support fix

[Olivier Galibert]

On Thu, May 10, 2001 at 08:59:24PM +0200, Jes Sorensen wrote:
> Thanks, I'll put that in the next driver release as well.

Good.  The only bad thing is that even with this fix, the card doesn't
work (recieves, but never transmits).  I'll have to look into it
later, when I find time.

  OG.

Re: [patch] Acenic tigon 1 support fix

[Jes Sorensen]

>>>>> "Olivier" == Olivier Galibert <galibert@pobox.com> writes:

Olivier> On Thu, May 10, 2001 at 08:59:24PM +0200, Jes Sorensen wrote:
>> Thanks, I'll put that in the next driver release as well.

Olivier> Good.  The only bad thing is that even with this fix, the
Olivier> card doesn't work (recieves, but never transmits).  I'll have
Olivier> to look into it later, when I find time.

I wouldn't be surprised if the Tigon I support died with the zero copy
changes. I haven't tested Tigon I cards for a long time (at least not
this year) but if I find some time (wont be soon ;-) I might take a
look.

Cheers
Jes