From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756132AbcKWDBD (ORCPT ); Tue, 22 Nov 2016 22:01:03 -0500 Received: from mail-pg0-f43.google.com ([74.125.83.43]:33823 "EHLO mail-pg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755615AbcKWDBB (ORCPT ); Tue, 22 Nov 2016 22:01:01 -0500 Subject: Re: [PATCH 2/2] PCI: iproc: avoid maybe-uninitialized warning To: Arnd Bergmann References: <20161122141844.1655574-1-arnd@arndb.de> <20161122141844.1655574-2-arnd@arndb.de> <31c4c52b-3de5-2277-7a44-2a4231531074@broadcom.com> <2504851.C6gOdhdaGF@wuerfel> Cc: Bjorn Helgaas , Ray Jui , Scott Branden , Jon Mason , bcm-kernel-feedback-list@broadcom.com, Oza Oza , "Dmitry V. Krivenok" , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Ray Jui Message-ID: Date: Tue, 22 Nov 2016 19:00:58 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:50.0) Gecko/20100101 Thunderbird/50.0 MIME-Version: 1.0 In-Reply-To: <2504851.C6gOdhdaGF@wuerfel> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/22/2016 1:15 PM, Arnd Bergmann wrote: > On Tuesday, November 22, 2016 9:45:24 AM CET Ray Jui wrote: >>> diff --git a/drivers/pci/host/pcie-iproc.c b/drivers/pci/host/pcie-iproc.c >>> index 857ff5198317..0359569c8d78 100644 >>> --- a/drivers/pci/host/pcie-iproc.c >>> +++ b/drivers/pci/host/pcie-iproc.c >>> @@ -936,6 +936,7 @@ static int iproc_pcie_setup_ib(struct iproc_pcie *pcie, >>> >>> } >>> } >>> + ret = -EINVAL; >>> err_ib: >>> dev_err(dev, "unable to configure inbound mapping\n"); >>> dev_err(dev, "axi %pap, pci %pap, res size %pap\n", >>> >> >> This change is good, but in my opinion, a further improvement for >> clarity would be to initialize 'ret' to -EINVAL in the beginning of this >> function when 'ret' is declared. What do you think? >> > > I never do that, see https://rusty.ozlabs.org/?p=232 for a great > explanation about why. > > Arnd > Okay got it. Thanks! Ray