Re: [PATCH] pwm: atmel: enable clk when pwm already enabled in bootloader

Uwe Kleine-König
2023-07-10T19:16:09Z

[-- Attachment #1: Type: text/plain, Size: 766 bytes --]

Hello,

On Mon, Jul 10, 2023 at 05:00:45PM +0200, Thierry Reding wrote:
> On Mon, Jul 10, 2023 at 10:42:14PM +0800, Guiting Shen wrote:
> > + err = clk_enable(atmel_pwm->clk);
> > + if (err) {
> > + dev_err(atmel_pwm->chip.dev, "enable clock error\n");
>
> Might be worth to include the error code in the error message to make it
> easier to diagnose where the issue is. Something like:
>
> dev_err(atmel_pwm->chip.dev, "failed to enable clock: %d\n", err);

Or (IMHO) still better:

dev_err(atmel_pwm->chip.dev, "failed to enable clock: %pe\n", ERR_PTR(err));

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]