Re: [PATCH] pwm: atmel: enable clk when pwm already enabled in bootloader

Guiting Shen
2023-07-11T02:38:06Z

On Tue, Jul 11, 2023 at 03:15:50AM GMT+8, Uwe Kleine-König wrote:
> Hello,
>
> On Mon, Jul 10, 2023 at 05:00:45PM +0200, Thierry Reding wrote:
>> On Mon, Jul 10, 2023 at 10:42:14PM +0800, Guiting Shen wrote:
>>> + err = clk_enable(atmel_pwm->clk);
>>> + if (err) {
>>> + dev_err(atmel_pwm->chip.dev, "enable clock error\n");
>>
>> Might be worth to include the error code in the error message to make it
>> easier to diagnose where the issue is. Something like:
>>
>> dev_err(atmel_pwm->chip.dev, "failed to enable clock: %d\n", err);
>
> Or (IMHO) still better:
>
> dev_err(atmel_pwm->chip.dev, "failed to enable clock: %pe\n", ERR_PTR(err));
>

Ok, I will add it in v2 patch.

I also found that the clk_enable() of atmel_pwm_apply() do not include
the error code in the error message. Do I also add this in v2 patch or
in separate patch?

--
Regards,
Guiting Shen