linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hangyu Hua <hbh25y@gmail.com>
To: Shuah Khan <skhan@linuxfoundation.org>,
	valentina.manea.m@gmail.com, shuah@kernel.org,
	gregkh@linuxfoundation.org, khoroshilov@ispras.ru
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: usbip: fix a refcount leak in stub_probe()
Date: Fri, 8 Apr 2022 09:59:32 +0800	[thread overview]
Message-ID: <d40cb8cf-a92d-3f87-3af1-0422f8d8264f@gmail.com> (raw)
In-Reply-To: <7c584e2d-1c23-3df9-7e4e-c4d9a9014224@linuxfoundation.org>

Hi Shuah,

I find this by code review. Do i really need to add this to commit log? 
This look like a little weird.

Thanks

On 2022/4/8 00:31, Shuah Khan wrote:
> On 4/6/22 8:22 PM, Hangyu Hua wrote:
>> usb_get_dev() is called in stub_device_alloc(). When stub_probe() fails
>> after that, usb_put_dev() needs to be called to release the reference.
>>
>> Fix this by moving usb_put_dev() to sdev_free error path handling.
>>
>> Fixes: 3ff67445750a ("usbip: fix error handling in stub_probe()")
>> Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
>> Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
>> ---
>>
>> v2: add more description of this patch.
> 
> Still missing details on how this problem was found. Please add them
> to the commit log.
> 
> thanks,
> -- Shuah

  reply	other threads:[~2022-04-08  1:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07  2:22 [PATCH v2] usb: usbip: fix a refcount leak in stub_probe() Hangyu Hua
2022-04-07 16:31 ` Shuah Khan
2022-04-08  1:59   ` Hangyu Hua [this message]
2022-04-08 15:04     ` Shuah Khan
2022-04-11  5:29       ` Hangyu Hua
2022-04-11 19:38         ` Shuah Khan
2022-04-12  1:26           ` Hangyu Hua

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d40cb8cf-a92d-3f87-3af1-0422f8d8264f@gmail.com \
    --to=hbh25y@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=khoroshilov@ispras.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=valentina.manea.m@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).