Re: [PATCH v3 4/8] clk: qcom: Add support for Camera Clock Controller on SA8775P

Taniya Das
2024-08-16T05:13:53Z

On 7/16/2024 5:37 PM, Konrad Dybcio wrote:
> On 15.07.2024 10:23 AM, Taniya Das wrote:
>> Add support for Camera Clock Controller on SA8755P platform.
>>
>> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
>> ---
>
> [...]
>
>> +
>> +static struct gdsc cam_cc_titan_top_gdsc = {
>> + .gdscr = 0x131bc,
>> + .en_rest_wait_val = 0x2,
>> + .en_few_wait_val = 0x2,
>> + .clk_dis_wait_val = 0xf,
>
> Shouldn't this also have a .cxcs relating to GCC_CAMERA_AHB_CLK?
>
> Konrad

Not really required, this external GCC clock would be kept always
enabled from GCC driver.

--
Thanks & Regards,
Taniya Das.