From: "Saleem, Shiraz" <shiraz.saleem@intel.com>
To: Joe Perches <joe@perches.com>,
"Ismail, Mustafa" <mustafa.ismail@intel.com>
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: RE: irdma: utils.c typos in irdma_cqp_gather_stats_gen1 ?
Date: Mon, 7 Jun 2021 14:54:36 +0000 [thread overview]
Message-ID: <d41c5503b5b74996af3f3c1853a67935@intel.com> (raw)
In-Reply-To: <9e07e80d8aa464447323670fd810f455d53f76f3.camel@perches.com>
> Subject: irdma: utils.c typos in irdma_cqp_gather_stats_gen1 ?
>
> There are some odd mismatches in field and access index.
> These may be simple cut/paste typos.
>
> Are these intentional?
No. Accidental. Likely cut/copy mistake. I will send a fix. Thanks Joe!
Shiraz
>
> ip4txfrag is set to the value from IP4RXFRAGS
>
> 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1753) gather_stats-
> >ip4txfrag =
> 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1754) rd64(dev-
> >hw,
> 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1755) dev-
> >hw_stats_regs_64[IRDMA_HW_STAT_INDEX_IP4RXFRAGS]
> 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1756) +
> stats_inst_offset_64);
>
> ip4txfrag is set again a few lines later, so the case above is probably a defect.
>
> 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1769) gather_stats-
> >ip4txfrag =
> 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1770) rd64(dev-
> >hw,
> 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1771) dev-
> >hw_stats_regs_64[IRDMA_HW_STAT_INDEX_IP4TXFRAGS]
> 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1772) +
> stats_inst_offset_64);
>
> And here ip6txfrag is set to the value of IP6RXFRAGS
>
> 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1785) gather_stats-
> >ip6txfrags =
> 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1786) rd64(dev-
> >hw,
> 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1787) dev-
> >hw_stats_regs_64[IRDMA_HW_STAT_INDEX_IP6RXFRAGS]
> 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1788) +
> stats_inst_offset_64);
>
next prev parent reply other threads:[~2021-06-07 14:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-06 1:10 irdma: utils.c typos in irdma_cqp_gather_stats_gen1 ? Joe Perches
2021-06-07 14:54 ` Saleem, Shiraz [this message]
2021-06-07 15:07 ` Joe Perches
2021-06-07 22:40 ` Saleem, Shiraz
2021-06-07 23:37 ` Joe Perches
2021-06-08 16:18 ` Saleem, Shiraz
2021-06-08 16:25 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d41c5503b5b74996af3f3c1853a67935@intel.com \
--to=shiraz.saleem@intel.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mustafa.ismail@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox