From: Dave Hansen <dave.hansen@intel.com>
To: Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de,
kan.liang@linux.intel.com, mingo@kernel.org,
peterz@infradead.org, tony.luck@intel.com,
pawan.kumar.gupta@linux.intel.com
Subject: Re: [PATCH 2/5] x86/cpu: Expose only stepping min/max interface
Date: Fri, 13 Dec 2024 08:27:44 -0800 [thread overview]
Message-ID: <d42655ed-d1a4-48e7-ab37-e3449801107d@intel.com> (raw)
In-Reply-To: <20241213162443.GGZ1xfyw_EZBrn1i4B@fat_crate.local>
On 12/13/24 08:24, Borislav Petkov wrote:
> drivers/edac/i10nm_base.c:951:90: error: macro "X86_MATCH_VFM_STEPPINGS" requires 4 arguments, but only 3 given
> 951 | X86_MATCH_VFM_STEPPINGS(INTEL_ATOM_DARKMONT_X, X86_STEPPINGS(0x0, 0xf), &gnr_cfg),
> | ^
I'll fix that up.
>> + X86_MATCH_VFM_STEPPINGS(INTEL_ATOM_CRESTMONT_X, 0x0, 0xf, &gnr_cfg),
>> + X86_MATCH_VFM_STEPPINGS(INTEL_ATOM_CRESTMONT, 0x0, 0xf, &gnr_cfg),
>
> Aren't those supposed to be:
>
> X86_MATCH_VFM_STEPPINGS(INTEL_ATOM_CRESTMONT, X86_STEPPING_MIN, X86_STEPPING_MAX, &gnr_cfg),
>
> And while we're adding new defines, can we shorten them too?
>
> X86_MATCH_VFM_STP(INTEL_ATOM_CRESTMONT, X86_STP_MIN, X86_STP_MAX, &gnr_cfg),
>
> all that "STEPPING" is screaming at me! :-P
I was trying to minimize the churn but that seems like a good thing to
add. I'll also shorten the name.
next prev parent reply other threads:[~2024-12-13 16:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 19:38 [PATCH 0/5] x86/cpu: Remove duplicate microcode version matching infrastructure Dave Hansen
2024-12-06 19:38 ` [PATCH 1/5] x86/cpu: Introduce new microcode matching helper Dave Hansen
2024-12-10 5:46 ` Chao Gao
2024-12-13 17:55 ` Dave Hansen
2024-12-06 19:38 ` [PATCH 2/5] x86/cpu: Expose only stepping min/max interface Dave Hansen
2024-12-13 16:24 ` Borislav Petkov
2024-12-13 16:27 ` Dave Hansen [this message]
2024-12-13 17:44 ` Dave Hansen
2024-12-06 19:38 ` [PATCH 3/5] x86/cpu: Replace PEBS use of 'x86_cpu_desc' use with 'x86_cpu_id' Dave Hansen
2024-12-06 19:55 ` Luck, Tony
2024-12-06 19:58 ` Dave Hansen
2024-12-06 23:58 ` Pawan Gupta
2024-12-07 0:02 ` Dave Hansen
2024-12-06 19:38 ` [PATCH 4/5] x86/cpu: Move AMD erratum 1386 table over to 'x86_cpu_id' Dave Hansen
2024-12-06 19:38 ` [PATCH 5/5] x86/cpu: Remove 'x86_cpu_desc' infrastructure Dave Hansen
2024-12-09 13:06 ` [PATCH 0/5] x86/cpu: Remove duplicate microcode version matching infrastructure Qiuxu Zhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d42655ed-d1a4-48e7-ab37-e3449801107d@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox