From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F7393F23B1 for ; Thu, 9 Jul 2026 10:01:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783591306; cv=none; b=g/cx5QDN5brobJhxcYGnKNOxNsjXQ4tAKS//0GMcqQeWDwkk4F/VHr+xToAQnYTlZp2TNw3hxkGZFQGW8ztzNXF9U7xi2Qhm0HNJJ6qIWCZmNfbblWb5FBNTV+vZFr/2mSiEoDk+6FRj+7qa1xZU+Zh/oEkFmvD7U1cILIp/iQs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783591306; c=relaxed/simple; bh=TEl/JPlrmtxrSDM/EEqovHLemprWyXvIvJ/ofjuX++I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=a718AgzcDcCpN5prSSPHIRcrt6xu72gzjaCLvAzpiB/dCKsf9mVo3LWBVMWY5CJYTO43iU07050hZvK8sLIVQH3RcwpEtlnPc3E5HGEoFAWoKkp9sZgJTuIHVAx+ACmrBpeq40jiRWI8oP8+qUH8LkSGrcyGWhTNuSBkbr3o9ic= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=D7dKW8LG; arc=none smtp.client-ip=198.175.65.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="D7dKW8LG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1783591305; x=1815127305; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=TEl/JPlrmtxrSDM/EEqovHLemprWyXvIvJ/ofjuX++I=; b=D7dKW8LGxbxaTWsh2wiRsh1Yh9wqysuKJsXFMiMZ7RYGHxbu6C/atLPe xT1CIPRUJt0kSvJdXnlhK3YA8k82dvMhV3mxZn/I1OQJjI4tDge0RmZxC MhoiM1C49+ii9ga5zqsXX7t6QOk6Nw3JzH5rSIQmr4kr7cBunTEsaHxU7 sKuu9AQXor5pp/KgZiv4eptqMckV+COCofpBzhMywSuz05XdZMRigoKZY 2Y6eS3RjlmBXDQs5x3C/zi6Hc4TNqlms9sCb7TmF51GS0mnorSZKgeW4d S8dXWoXFVgNxwpB43Z/bLvQBjQkE6A+3u0ZEewK7UCpooySOrYl9UfWQ3 g==; X-CSE-ConnectionGUID: lvSR9NxURfOhtd0ll5CQ5g== X-CSE-MsgGUID: uxs8O3ioSwqI4te9IZ6f7g== X-IronPort-AV: E=McAfee;i="6800,10657,11841"; a="84239919" X-IronPort-AV: E=Sophos;i="6.25,154,1779174000"; d="scan'208";a="84239919" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2026 03:01:44 -0700 X-CSE-ConnectionGUID: W2Ap1TupQRe4smn0ovnd5A== X-CSE-MsgGUID: MK7szr82QB2Pw3ZBjm7NQg== X-ExtLoop1: 1 Received: from klitkey1-mobl1.ger.corp.intel.com (HELO [10.245.244.49]) ([10.245.244.49]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2026 03:01:39 -0700 Message-ID: Date: Thu, 9 Jul 2026 12:02:17 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] drm: Guard DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE To: "Borah, Chaitanya Kumar" , Robert Mader , dri-devel@lists.freedesktop.org Cc: Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Harry Wentland , Daniel Stone , Uma Shankar , Louis Chauvet , Melissa Wen , Simon Ser , Pekka Paalanen , Leandro Ribeiro References: <20260703073230.19982-1-robert.mader@collabora.com> <6d8806b8-fc71-4699-82c4-7189a0ea2284@intel.com> <7d58b289-eabe-4d68-9080-c7202b0f60a0@intel.com> Content-Language: en-US From: Maarten Lankhorst In-Reply-To: <7d58b289-eabe-4d68-9080-c7202b0f60a0@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hey, On 7/9/26 08:44, Borah, Chaitanya Kumar wrote: > > > On 7/7/2026 6:31 PM, Maarten Lankhorst wrote: >> Hey, >> >> On 7/7/26 10:03, Borah, Chaitanya Kumar wrote: >>> >>> On 7/3/2026 1:02 PM, Robert Mader wrote: >>>> The client cap is currently advertised unconditionally, even for drivers >>>> that do not support plane color pipelines. If clients supporting the later, >>> s/later/latter >>> >>>> like Wayland compositors or tools like drm_info, enable the client cap on >>>> such drivers they will be left without both color pipeline and the legacy >>>> properties COLOR_ENCODING and COLOR_RANGE, effectively breaking YUV->RGB >>>> conversion support. >>>> >>>> Prevent that by only marking the cap supported if there are actually planes >>>> with color pipelines. >>>> >>>> Note: while the color pipeline replacement for the legacy properties is >>>> still under review (1), we can assume that it will work as a drop-in >>>> replacement. >>> This change will but a driver can also choose to export colorops like programmable CTM_3x4 to achieve the same. >>> >>> We should also perhaps document this somewhere that if a driver supports LEGACY properties, it is imperative to implement some version of it with the color pipeline line property. >> Would this be doable inside drm core? Implement the color pipeline properties, get the fixed pipeline for free? > > Right now, the Bypass(default) pipeline is automatically created when we call drm_plane_create_color_pipeline_property(), we could come up with a similar helper that could also create a pipeline that replaces the legacy properties. > > But this can't replace the existing helper entirely because some HW (though unlikely) might not support YUV buffers. No need to do this for free, but a cheaper way for drivers to implement legacy properties by only implementing the pipeline would be nice, similar to how atomic also implements legacy modesetting and universal planes. Kind regards, ~Maarten Lankhorst